QPR-12119 make source private and remove lock

Author: pcaspers

OREData/ored/utilities/log.cpp

@@ -336,8 +336,7 @@ void Log::removeAllLoggers() {
     independentLoggers_.clear();
 }
 
-string Log::source(const char* filename, int lineNo) {
-    boost::shared_lock<boost::shared_mutex> lock(mutex_);
+string Log::source(const char* filename, int lineNo) const {
     string filepath;
     if (rootPath_.empty()) {
         filepath = filename;

OREData/ored/utilities/log.hpp

@@ -428,19 +428,17 @@ class Log : public QuantLib::Singleton<Log, std::integral_constant<bool, true>>
      */
     void removeAllLoggers();
 
-    std::string source(const char* filename, int lineNo);
-
     void addExcludeFilter(const std::string&, const std::function<bool(const std::string&)>);
 
     void removeExcludeFilter(const std::string&);
 
     bool checkExcludeFilters(const std::string&);
 
-    //! macro utility function - do not use directly
+    //! macro utility function - do not use directly, not thread safe
     void header(unsigned m, const char* filename, int lineNo);
-    //! macro utility function - do not use directly
+    //! macro utility function - do not use directly, not thread safe
     std::ostream& logStream() { return ls_; }
-    //! macro utility function - do not use directly
+    //! macro utility function - do not use directly, not thread safe
     void log(unsigned m);
 
     //! mutex to acquire locks
@@ -500,6 +498,9 @@ class Log : public QuantLib::Singleton<Log, std::integral_constant<bool, true>>
 private:
     Log();
 
+    // not thread safe
+    std::string source(const char* filename, int lineNo) const;
+
     std::map<std::string, boost::shared_ptr<Logger>> loggers_;
     std::map<std::string, boost::shared_ptr<IndependentLogger>> independentLoggers_;
     bool enabled_;