Skip to content

Commit eb9c028

Browse files
pcaspersjenkins
authored andcommitted
always allow overwrite as long as we use manual registration of builders for windows
1 parent 5e8ba6d commit eb9c028

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

OREData/ored/portfolio/enginefactory.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,8 @@ void EngineFactory::registerBuilder(const boost::shared_ptr<EngineBuilder>& buil
123123
const string& modelName = builder->model();
124124
const string& engineName = builder->engine();
125125
auto key = make_tuple(modelName, engineName, builder->tradeTypes());
126-
if(allowOverwrite)
126+
// FIXME workaround to allow manual registration of builders on windows, remove once this is resolved
127+
if(true || allowOverwrite)
127128
builders_.erase(key);
128129
QL_REQUIRE(builders_.insert(make_pair(key, builder)).second,
129130
"EngineFactory: duplicate engine builder for (" << modelName << "/" << engineName << "/"
@@ -160,7 +161,8 @@ boost::shared_ptr<EngineBuilder> EngineFactory::builder(const string& tradeType)
160161
}
161162

162163
void EngineFactory::registerLegBuilder(const boost::shared_ptr<LegBuilder>& legBuilder, const bool allowOverwrite) {
163-
if(allowOverwrite)
164+
// FIXME workaround to allow manual registration of builders on windows, remove once this is resolved
165+
if(true || allowOverwrite)
164166
legBuilders_.erase(legBuilder->legType());
165167
QL_REQUIRE(legBuilders_.insert(make_pair(legBuilder->legType(), legBuilder)).second,
166168
"EngineFactory duplicate leg builder for '" << legBuilder->legType()

0 commit comments

Comments
 (0)