QPR-11772 write out conventions only if non-empty

pcaspers · jenkins · commit f73100bafd08 · 2023-08-14T09:56:55.000Z
diff --git a/OREData/ored/configuration/yieldcurveconfig.cpp b/OREData/ored/configuration/yieldcurveconfig.cpp
@@ -478,7 +478,8 @@ XMLNode* YieldCurveSegment::toXML(XMLDocument& doc) {
         XMLUtils::appendNode(node, quotesNode);
     }
 
-    XMLUtils::addChild(doc, node, "Conventions", conventionsID_);
+    if (!conventionsID_.empty())
+        XMLUtils::addChild(doc, node, "Conventions", conventionsID_);
     XMLUtils::addChild(doc, node, "PillarChoice", ore::data::to_string(pillarChoice_));
     return node;
 }

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,8 @@ XMLNode* YieldCurveSegment::toXML(XMLDocument& doc) {`
`478`	`478`	`XMLUtils::appendNode(node, quotesNode);`
`479`	`479`	`}`
`480`	`480`
`481`		`- XMLUtils::addChild(doc, node, "Conventions", conventionsID_);`
	`481`	`+ if (!conventionsID_.empty())`
	`482`	`+ XMLUtils::addChild(doc, node, "Conventions", conventionsID_);`
`482`	`483`	`XMLUtils::addChild(doc, node, "PillarChoice", ore::data::to_string(pillarChoice_));`
`483`	`484`	`return node;`
`484`	`485`	`}`