changes made to swig based off initial comments

Author: Andrew Packard

OREAnalytics-SWIG/SWIG/orea_app.i

@@ -138,12 +138,12 @@ public:
     // TODO: API for setting a sensitivity stream
     // const boost::shared_ptr<SensitivityStream>& sensitivityStream();
     // Setters for exposure simulation
-    void setSimmVersion(const std::string& s) { simmVersion_ = s; }
+    void setSimmVersion(const std::string& s);
     void setCrifFromBuffer(const std::string& csvBuffer,
                            char eol = '\n', char delim = ',', char quoteChar = '\0', char escapeChar = '\\');
-    void setSimmCalculationCurrency(const std::string& s) { simmCalculationCurrency_ = s; }
-    void setSimmResultCurrency(const std::string& s) { simmResultCurrency_ = s; }
-    void setSimmReportingCurrency(const std::string& s) { simmReportingCurrency_ = s; }
+    void setSimmCalculationCurrency(const std::string& s);
+    void setSimmResultCurrency(const std::string& s);
+    void setSimmReportingCurrency(const std::string& s);
     void setAmc(bool b);
     void setAmcTradeTypes(const std::string& s); // todo: parse to set<string>
     void setExposureBaseCurrency(const std::string& s);
@@ -232,9 +232,9 @@ public:
     void setCreditMigrationOutputFiles(const std::string& s) { creditMigrationOutputFiles_ = s; }
     // Setters for cashflow npv and dynamic backtesting
     void setCashflowHorizon(const std::string& s); 
-    void setPortfolioFilterDate(const std::string& s); 
+    void setPortfolioFilterDate(const std::string& s);
     // Set list of analytics that shall be run
-    void setAnalytics(const std::string& s); 
+    void setAnalytics(const std::string& s);
     void insertAnalytic(const std::string& s); 
 };
 

OREData-SWIG/SWIG/ored_calendarAdjustmentConfig.i

@@ -1,5 +1,5 @@
 /*
- Copyright (C) 2018, 2020 Quaternion Risk Management Ltd
+ Copyright (C) 2023 Quaternion Risk Management Ltd
  All rights reserved.
 
  This file is part of ORE, a free-software/open-source library
@@ -20,7 +20,7 @@
 #define ored_CalendarAdjustmentConfig_i
 
 %{
-// put c++ declarations here
+
 using ore::data::CalendarAdjustmentConfig;
 using std::map;
 using std::set;
@@ -33,36 +33,30 @@ using QuantLib::Calendar;
 %shared_ptr(CalendarAdjustmentConfig)
 class CalendarAdjustmentConfig {
   public:
-    // default constructor
+
     CalendarAdjustmentConfig();
 
-    // This method adds d to the list of holidays for cal name.
     void addHolidays(const string& calname, const Date& d);
 
-    // This method adds d to the list of business days for cal name.
     void addBusinessDays(const string& calname, const Date& d);
 
-    // This method adds s as a base calendar for cal name.
     void addBaseCalendar(const string& calname, const string& d);
 
-    // Returns all the holidays for a given cal name
-    const set<Date>& getHolidays(const string& calname) const;
+    const set<Date>& getHolidays(const string& calname);
 
-    // Returns all the business days for a given calname
-    const set<Date>& getBusinessDays(const string& calname) const;
+    const set<Date>& getBusinessDays(const string& calname);
 
     set<string> getCalendars() const;
 
-    const string& getBaseCalendar(const string& calname) const;
+    const string& getBaseCalendar(const string& calname);
 
-    // add all holidays and business days from c to this instance
     void append(const CalendarAdjustmentConfig& c);
   private:
     map<string, string> baseCalendars_;
     map<string, set<Date>> additionalHolidays_;
     map<string, set<Date>> additionalBusinessDays_;
 
-    string normalisedName(const string&) const;
+    string normalisedName(const string&);
 };