Skip to content

Commit 75c7376

Browse files
committed
Fix bug where bot would crash if mentor didn't have skillsets column
1 parent 19e8ee1 commit 75c7376

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

logging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ formatters:
55
format: '%(asctime)s - %(name)s - %(levelname)s - %(message)s'
66
filters:
77
messages:
8-
(): 'pybot.logging.SlackMessageFilter'
8+
(): 'pybot.customLogging.SlackMessageFilter'
99

1010
handlers:
1111
console:
File renamed without changes.

pybot/plugins/airtable/api.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,20 @@ async def find_mentors_with_matching_skillsets(self, skillsets):
8383
try:
8484
for mentor in mentors:
8585
if all(
86-
skillset in mentor["fields"]["Skillsets"] for skillset in skillsets
86+
skillset in mentor["fields"].get("Skillsets", [])
87+
for skillset in skillsets
8788
):
8889
complete_match.append(mentor["fields"])
8990
if any(
9091
mentor["fields"] not in complete_match
91-
and skillset in mentor["fields"]["Skillsets"]
92+
and skillset in mentor["fields"].get("Skillsets", [])
9293
for skillset in skillsets
9394
):
9495
partial_match.append(mentor["fields"])
9596
except Exception as e:
97+
logger.exception(
98+
"Exception while trying to find filter mentors by skillset"
99+
)
96100
return []
97101

98102
if len(complete_match) < 5:

0 commit comments

Comments
 (0)