Fix SlackAPI session initialization race condition ( Sentry ID OPERATIONCODE-PYBOT-4T )

The SlackAPI was being initialized in plugin.load() before the aiohttp
session existed, causing '_session' to be None. This led to production
errors: "AttributeError: 'NoneType' object has no attribute 'request'".

Solution:
- Defer SlackAPI initialization to startup callback after session creation
- Make _initialize_api() idempotent to preserve test mocks
- Update test fixtures to manually trigger initialization when needed

Author: Irving Popovetsky

docker-build.sh

@@ -1,5 +1,11 @@
 #!/bin/sh -ex
 
+# Refresh AWS ECR login
+AWS_REGION=${AWS_REGION:-us-east-2}
+echo "Refreshing AWS ECR login for region ${AWS_REGION}..."
+aws ecr get-login-password --region ${AWS_REGION} | \
+  docker login --username AWS --password-stdin 633607774026.dkr.ecr.${AWS_REGION}.amazonaws.com
+
 # Build and push ARM64 image using buildx with provenance disabled
 docker buildx build \
   --platform linux/arm64 \

pybot/_vendor/sirbot/plugins/slack/plugin.py

@@ -91,15 +91,25 @@ def __init__(
 
     def load(self, sirbot: Any) -> None:
         LOG.info("Loading slack plugin")
-        self.api = SlackAPI(session=sirbot.http_session, token=self.token)
+        # Store reference to sirbot for later initialization
+        self._sirbot = sirbot
 
         sirbot.router.add_route("POST", "/slack/events", endpoints.incoming_event)
         sirbot.router.add_route("POST", "/slack/commands", endpoints.incoming_command)
         sirbot.router.add_route("POST", "/slack/actions", endpoints.incoming_action)
 
+        # Initialize API after session is created
+        sirbot.on_startup.append(self._initialize_api)
+
         if self.bot_user_id and not self.bot_id:
             sirbot.on_startup.append(self.find_bot_id)
 
+    async def _initialize_api(self, app: Any) -> None:
+        """Initialize SlackAPI after http_session is created."""
+        if self.api is None:
+            LOG.info("Initializing Slack API client")
+            self.api = SlackAPI(session=self._sirbot.http_session, token=self.token)
+
     def on_event(self, event_type: str, handler: AsyncHandler, wait: bool = True) -> None:
         """Register handler for an event."""
         handler = _ensure_async(handler)

tests/conftest.py

@@ -44,14 +44,19 @@ async def bot() -> SirBot:
     b.load_plugin(airtable)
     b.load_plugin(api)
 
+    # Manually initialize the Slack API for tests that don't use aiohttp_client
+    # (which would trigger startup callbacks automatically).
+    # The _initialize_api method is idempotent, so it won't overwrite mocks.
+    await slack._initialize_api(b)
+
     yield b
 
     # Cleanup session
     await b["http_session"].close()
 
 
 @pytest.fixture
-def slack_bot(bot: SirBot):
+async def slack_bot(bot: SirBot):
     slack = SlackPlugin(
         token="token",
         verify="supersecuretoken",
@@ -60,4 +65,6 @@ def slack_bot(bot: SirBot):
     )
     endpoints.slack.create_endpoints(slack)
     bot.load_plugin(slack)
+    # Manually initialize the Slack API (idempotent, won't overwrite existing)
+    await slack._initialize_api(bot)
     return bot