fix: join_team was broken due to an Python 3.14 incompatibility. improved the tests and verified no other of this class of errors exist

Author: Irving Popovetsky

pybot/_vendor/sirbot/plugins/slack/plugin.py

@@ -2,7 +2,7 @@
 Vendored sirbot Slack plugin for Python 3.12+
 """
 
-import asyncio
+import inspect
 import logging
 import os
 from collections.abc import Callable, Coroutine
@@ -24,7 +24,7 @@
 
 def _ensure_async(handler: Callable) -> AsyncHandler:
     """Ensure handler is an async function."""
-    if not asyncio.iscoroutinefunction(handler):
+    if not inspect.iscoroutinefunction(handler):
         raise TypeError(
             f"Handler {handler.__name__} must be an async function (defined with 'async def')"
         )

pybot/endpoints/slack/events.py

@@ -29,15 +29,14 @@ async def team_join(event: Event, app: SirBot) -> None:
     user_id = event["user"]["id"]
 
     *user_messages, community_message, outreach_team_message = build_messages(user_id)
-    futures = [
-        send_user_greetings(user_messages, slack_api),
-        send_community_notification(community_message, slack_api),
-        send_community_notification(outreach_team_message, slack_api),
-    ]
 
     logger.info(f"New team join event: {event}")
     await asyncio.sleep(30)
-    await asyncio.wait(futures)
+    await asyncio.gather(
+        send_user_greetings(user_messages, slack_api),
+        send_community_notification(community_message, slack_api),
+        send_community_notification(outreach_team_message, slack_api),
+    )
 
     headers = await get_backend_auth_headers(app.http_session)
     if headers:

pybot/plugins/api/plugin.py

@@ -1,4 +1,4 @@
-import asyncio
+import inspect
 import logging
 from collections import defaultdict
 from collections.abc import Callable, Coroutine
@@ -14,7 +14,7 @@
 
 def _ensure_async(handler: Callable) -> AsyncHandler:
     """Ensure handler is an async function."""
-    if not asyncio.iscoroutinefunction(handler):
+    if not inspect.iscoroutinefunction(handler):
         raise TypeError(
             f"Handler {handler.__name__} must be an async function (defined with 'async def')"
         )

tests/endpoints/slack/test_slack_events.py

@@ -1,14 +1,17 @@
-import asyncio
+import inspect
 import logging
+from unittest.mock import AsyncMock, patch
 
 from pybot import endpoints
-from tests.data.events import MESSAGE_DELETE, MESSAGE_EDIT, PLAIN_MESSAGE
+from pybot.endpoints.slack.events import team_join
+from pybot._vendor.slack.events import Event
+from tests.data.events import MESSAGE_DELETE, MESSAGE_EDIT, PLAIN_MESSAGE, TEAM_JOIN
 
 
 async def test_team_join_handler_exists(bot):
     endpoints.slack.create_endpoints(bot["plugins"]["slack"])
 
-    assert asyncio.iscoroutinefunction(
+    assert inspect.iscoroutinefunction(
         bot["plugins"]["slack"].routers["event"]._routes["team_join"]["*"]["*"][0][0]
     )
 
@@ -35,3 +38,31 @@ async def test_no_other_messages_logged(bot, aiohttp_client, caplog):
     with caplog.at_level(logging.INFO):
         await client.post("/slack/events", json=PLAIN_MESSAGE)
     assert not any("CHANGE_LOGGING" in record.message for record in caplog.records)
+
+
+async def test_team_join_asyncio_gather_does_not_raise_typeerror(bot):
+    """
+    Regression test for Python 3.14 compatibility.
+
+    In Python 3.14, asyncio.wait() no longer accepts bare coroutines.
+    This test verifies that team_join uses asyncio.gather() correctly.
+    """
+    event = Event.from_http(TEAM_JOIN, verification_token="supersecuretoken")
+
+    with (
+        patch("pybot.endpoints.slack.events.asyncio.sleep", new_callable=AsyncMock),
+        patch(
+            "pybot.endpoints.slack.events.send_user_greetings", new_callable=AsyncMock
+        ),
+        patch(
+            "pybot.endpoints.slack.events.send_community_notification",
+            new_callable=AsyncMock,
+        ),
+        patch(
+            "pybot.endpoints.slack.events.get_backend_auth_headers",
+            new_callable=AsyncMock,
+            return_value={},
+        ),
+    ):
+        # This should not raise TypeError about coroutines
+        await team_join(event, bot)

tests/test_upgrade_safety.py

@@ -7,8 +7,8 @@
 - Handler registration verification
 """
 
-import asyncio
 import importlib
+import inspect
 
 import pytest
 
@@ -70,12 +70,12 @@ def test_slash_commands_are_async(self):
         for handler in handlers:
             # Get the wrapped function if decorated
             func = getattr(handler, "__wrapped__", handler)
-            assert asyncio.iscoroutinefunction(func), f"{handler.__name__} must be async"
+            assert inspect.iscoroutinefunction(func), f"{handler.__name__} must be async"
 
     def test_event_handlers_are_async(self):
         from pybot.endpoints.slack.events import team_join
 
-        assert asyncio.iscoroutinefunction(team_join), "team_join must be async"
+        assert inspect.iscoroutinefunction(team_join), "team_join must be async"
 
     def test_action_handlers_are_async(self):
         from pybot.endpoints.slack.actions.general_actions import (
@@ -86,7 +86,7 @@ def test_action_handlers_are_async(self):
 
         handlers = [claimed, delete_message, reset_claim]
         for handler in handlers:
-            assert asyncio.iscoroutinefunction(handler), f"{handler.__name__} must be async"
+            assert inspect.iscoroutinefunction(handler), f"{handler.__name__} must be async"
 
 
 class TestPluginLoading: