Skip to content

Commit 4743f62

Browse files
Update dependency Azure.Identity to 1.19.0 (#5332)
* Update dependency Azure.Identity to 1.19.0 * Switch to `ManagedIdentityId` for token credential authentication --------- Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com> Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
1 parent 49f39ba commit 4743f62

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<ItemGroup Label="Versions for direct package references">
77
<PackageVersion Include="Autofac" Version="9.0.0" />
88
<PackageVersion Include="AWSSDK.CloudWatch" Version="4.0.7" />
9-
<PackageVersion Include="Azure.Identity" Version="1.17.1" />
9+
<PackageVersion Include="Azure.Identity" Version="1.19.0" />
1010
<PackageVersion Include="Azure.Monitor.Query.Metrics" Version="1.0.0" />
1111
<PackageVersion Include="Azure.ResourceManager.ServiceBus" Version="1.1.0" />
1212
<PackageVersion Include="ByteSize" Version="2.1.2" />

src/ServiceControl.Transports.ASBS/TokenCredentialAuthentication.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
namespace ServiceControl.Transports.ASBS
1+
#nullable enable
2+
namespace ServiceControl.Transports.ASBS
23
{
34
using Azure.Core;
45
using Azure.Identity;
@@ -13,21 +14,20 @@ public TokenCredentialAuthentication(string fullyQualifiedNamespace)
1314
Credential = new DefaultAzureCredential();
1415
}
1516

16-
public TokenCredentialAuthentication(string fullyQualifiedNamespace, string clientId)
17+
public TokenCredentialAuthentication(string fullyQualifiedNamespace, string? clientId)
1718
{
1819
FullyQualifiedNamespace = fullyQualifiedNamespace;
1920
ClientId = clientId;
20-
Credential = new ManagedIdentityCredential(clientId);
21+
Credential = new ManagedIdentityCredential(clientId is not null ? ManagedIdentityId.FromUserAssignedClientId(clientId) : ManagedIdentityId.SystemAssigned);
2122
}
2223

2324
public string FullyQualifiedNamespace { get; }
2425

2526
public TokenCredential Credential { get; }
2627

27-
public string ClientId { get; }
28+
public string? ClientId { get; }
2829

29-
public override ServiceBusAdministrationClient BuildManagementClient()
30-
=> new ServiceBusAdministrationClient(FullyQualifiedNamespace, Credential);
30+
public override ServiceBusAdministrationClient BuildManagementClient() => new(FullyQualifiedNamespace, Credential);
3131

3232
public override AzureServiceBusTransport CreateTransportDefinition(ConnectionSettings connectionSettings, TopicTopology topology)
3333
{

0 commit comments

Comments
 (0)