Skip to content

Commit 69d4591

Browse files
authored
Merge pull request #71 from PowderworksCode/fleet-vale-and-title
chore: take the fleet's managed files
2 parents ef746a7 + 9e7d68e commit 69d4591

3 files changed

Lines changed: 25 additions & 8 deletions

File tree

‎.github/workflows/fleet-lint.yml‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,13 @@ name: fleet-lint
1010
on:
1111
push:
1212
branches: [main]
13+
# `edited` joins the three default types because pr-title reads the title out
14+
# of the event payload: without it, a title corrected in response to the
15+
# check raises no event, and a re-run replays the payload that failed. The
16+
# only way left to clear the gate would be another push, which a title fix
17+
# does not have.
1318
pull_request:
19+
types: [opened, synchronize, reopened, edited]
1420
# Periodic coverage: these tools grow rules between releases, so a repository
1521
# nobody has touched can start failing for a reason worth knowing about.
1622
schedule:
@@ -209,7 +215,10 @@ jobs:
209215
# drives the compiler over the whole workspace, and a pull request that
210216
# touches no Rust cannot change what it would say.
211217
needs: changes
212-
if: needs.changes.outputs.rust == 'true'
218+
# Not on an edited title or body: nothing a description says changes what
219+
# the compiler sees, and this is the one job here that can run half an
220+
# hour. The rest are seconds and can afford to answer every event.
221+
if: needs.changes.outputs.rust == 'true' && github.event.action != 'edited'
213222
steps:
214223
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
215224
# Whether hawk applies is answered on the runner, after checkout: a

‎.vale.ini‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@
55
# clichés, redundancy — without imposing a voice on repositories whose readers
66
# are each other. A style guide can come later, from writing that exists.
77
StylesPath = .vale/styles
8-
MinAlertLevel = warning
8+
9+
# Errors only. The action runs reviewdog with fail-on-error, which fails a job on
10+
# any annotation it posts — warnings included — so a level reported is a level
11+
# enforced, whatever the rule's own severity says. Reporting errors alone is what
12+
# makes the levelling below mean anything. Lower this locally to read the advice.
13+
MinAlertLevel = error
914

1015
Packages = proselint, write-good
1116

@@ -20,8 +25,11 @@ BasedOnStyles = proselint, write-good
2025
write-good.ThereIs = warning
2126
write-good.So = warning
2227

23-
# Prose lives in sentences; a fenced block is code someone will run.
24-
BlockIgnores = (?s) *(```.*?```)
28+
# Prose lives in sentences; a fenced block is code someone will run. Anchored to
29+
# line starts because the unanchored form silently matched nothing: a fence with
30+
# no language tag was graded as prose, and `[PATHS]...` in a usage block read as
31+
# an ellipsis waiting to be typeset.
32+
BlockIgnores = (?sm)^ *```.*?^ *```
2533

2634
# `vale sync` writes the style packages here, README files and all, and Vale
2735
# then grades the prose of the linters it just downloaded.

‎scripts/publish.sh‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
#!/usr/bin/env bash
22
# Publish straitjacket to crates.io.
33
#
4+
# Fleet-managed by conf (.ordnung/managed/publishing/rust/publish.sh): edit it
5+
# there. The crate name is substituted from the repository name, so a crate
6+
# named differently from its repository needs a copy of its own.
7+
#
48
# Publishing is irreversible: a version can be yanked but never deleted, and a
59
# name/version pair can never be reused. The shape of this script follows from
610
# that.
@@ -34,10 +38,6 @@
3438
# CARGO_REGISTRIES_<NAME>_TOKEN ... or for --execute --registry <name>.
3539
# Neither is ever logged.
3640
#
37-
# Fleet-managed by conf (.ordnung/managed/publishing/rust/publish.sh): edit it
38-
# there. The crate name is substituted from the repository name, so a crate
39-
# named differently from its repository needs a copy of its own.
40-
#
4141
# straitjacket-allow-file:no-comments — this is the procedure for the one
4242
# action in the repository that cannot be undone, and sh has no
4343
# documentation-comment syntax to hoist the reasoning into.

0 commit comments

Comments
 (0)