Localize error strings

Localizes error strings in the following classes.
- TextLines
- TextEdit
- EditableText

Author: Kapil Borle

Engine/EditableText.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Management.Automation.Language;
 using System.Text;
@@ -126,34 +127,12 @@ private void ValidateTextEditExtent(TextEdit textEdit)
                 || textEdit.StartColumnNumber > Lines[textEdit.StartLineNumber - 1].Length
                 || textEdit.EndColumnNumber > Lines[textEdit.EndLineNumber - 1].Length + 1)
             {
-                // TODO Localize
-                throw new ArgumentException("TextEdit extent not completely contained in EditableText.");
+                throw new ArgumentException(String.Format(
+                    CultureInfo.CurrentCulture,
+                    Strings.EditableTextRangeIsNotContained));
             }
         }
 
-        private int GetOffset(int lineNumber, int columnNumber)
-        {
-            if (lineNumber < 1)
-            {
-                throw new ArgumentException("Line number must be greater than 0.", nameof(lineNumber));
-            }
-
-            if (columnNumber < 1)
-            {
-                throw new ArgumentException("Column number must be greater than 0.", nameof(lineNumber));
-            }
-
-            var zeroBasedLineNumber = lineNumber - 1;
-            var zeroBasedColumnNumber = columnNumber - 1;
-            var offset = 0;
-            for (var k = 0; k < zeroBasedLineNumber; k++)
-            {
-                offset += Lines[k].Length + NewLine.Length;
-            }
-
-            return offset + zeroBasedColumnNumber;
-        }
-
         private static string GetNewLineCharacters(string text, out string[] lines)
         {
             int numNewLineChars = GetNumNewLineCharacters(text, out lines);
@@ -178,8 +157,9 @@ private static int GetNumNewLineCharacters(string text, out string[] lines)
             int remainder = numCharDiff % (lines.Length - 1);
             if (remainder != 0)
             {
-                // TODO localize
-                throw new ArgumentException("Cannot determine line endings as the text probably contain mixed line endings.", nameof(text));
+                throw new ArgumentException(
+                    String.Format(CultureInfo.CurrentCulture, Strings.EditableTextInvalidLineEnding),
+                    nameof(text));
             }
 
             return numCharDiff / (lines.Length - 1);

Engine/Strings.resx

@@ -291,4 +291,19 @@
   <data name="ConfigurableScriptRuleNRE" xml:space="preserve">
     <value>"Argument should not be null.".</value>
   </data>
-</root>
+  <data name="TextLinesNoNullItem" xml:space="preserve">
+    <value>Line element cannot be null.</value>
+  </data>
+  <data name="TextEditNoNullItem" xml:space="preserve">
+    <value>Line element cannot be null.</value>
+  </data>
+  <data name="EditableTextRangeIsNotContained" xml:space="preserve">
+    <value>TextEdit extent not completely contained in EditableText.</value>
+  </data>
+  <data name="EditableTextRangeIsNotContained" xml:space="preserve">
+    <value>TextEdit extent not completely contained in EditableText.</value>
+  </data>
+  <data name="EditableTextInvalidLineEnding" xml:space="preserve">
+    <value>Cannot determine line endings as the text probably contain mixed line endings.</value>
+  </data>
+</root>

Engine/TextEdit.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Extensions;
 
@@ -86,8 +87,9 @@ public TextEdit(
 
             if (lines.Any(line => line == null))
             {
-                // TODO localize
-                throw new ArgumentException("Lines cannot contain a null element.", nameof(lines));
+                throw new ArgumentException(
+                    String.Format(CultureInfo.CurrentCulture,
+                    Strings.TextEditNoNullItem), nameof(lines));
             }
 
             Lines = lines.ToArray();

Engine/TextLines.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
@@ -41,8 +42,10 @@ public TextLines(IEnumerable<string> inputLines) : this()
             ThrowIfNull(inputLines, nameof(inputLines));
             if (inputLines.Any(line => line == null))
             {
-                // todo localize
-                throw new ArgumentException("Line element cannot be null.");
+                throw new ArgumentException(String.Format(
+                    CultureInfo.CurrentCulture,
+                    Strings.TextLinesNoNullItem));
+
             }
 
             lines = new LinkedList<string>(inputLines);

Rules/Strings.resx

@@ -954,4 +954,4 @@
   <data name="UseSupportsShouldProcessError" xml:space="preserve">
     <value>Whatif and/or Confirm manually defined in function {0}. Instead, please use SupportsShouldProcess attribute.</value>
   </data>
-</root>
+</root>