Forget try/catch

rjmholt · rjmholt · commit 7198d81fa0aa · 2019-04-24T14:48:45.000+10:00
diff --git a/PSCompatibilityCollector/PSCompatibilityCollector.psm1 b/PSCompatibilityCollector/PSCompatibilityCollector.psm1
@@ -2,18 +2,11 @@
 # Licensed under the MIT License.
 
 # Add the relevant binary module
-try
+if ($PSVersionTable.PSVersion.Major -ge 6)
 {
-    if ($PSVersionTable.PSVersion.Major -ge 6)
-    {
-        Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'netstandard2.0', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force
-    }
-    else
-    {
-        Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'net452', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force
-    }
+    Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'netstandard2.0', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force
 }
-catch
+else
 {
-    # Do nothing
+    Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'net452', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force
 }

Original file line number	Diff line number	Diff line change
`@@ -2,18 +2,11 @@`
`2`	`2`	`# Licensed under the MIT License.`
`3`	`3`
`4`	`4`	`# Add the relevant binary module`
`5`		`-try`
	`5`	`+if ($PSVersionTable.PSVersion.Major -ge 6)`
`6`	`6`	`{`
`7`		`- if ($PSVersionTable.PSVersion.Major -ge 6)`
`8`		`- {`
`9`		`- Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'netstandard2.0', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force`
`10`		`- }`
`11`		`- else`
`12`		`- {`
`13`		`- Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'net452', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force`
`14`		`- }`
	`7`	`+ Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'netstandard2.0', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force`
`15`	`8`	`}`
`16`		`-catch`
	`9`	`+else`
`17`	`10`	`{`
`18`		`- # Do nothing`
	`11`	`+ Import-Module ([System.IO.Path]::Combine($PSScriptRoot, 'net452', 'Microsoft.PowerShell.CrossCompatibility.dll')) -Force`
`19`	`12`	`}`