Make GetParameterAsts an extension method

Author: Kapil Borle

Engine/Extensions.cs

@@ -24,5 +24,23 @@ public static Range ToRange(this IScriptExtent extent)
                 extent.EndLineNumber,
                 extent.EndColumnNumber);
         }
+
+        public static ParameterAst[] GetParameterAsts(
+            this FunctionDefinitionAst functionDefinitionAst,
+            out ParamBlockAst paramBlockAst)
+        {
+            paramBlockAst = null;
+            if (functionDefinitionAst.Parameters != null)
+            {
+                return new List<ParameterAst>(functionDefinitionAst.Parameters).ToArray();
+            }
+            else if (functionDefinitionAst.Body.ParamBlock?.Parameters != null)
+            {
+                paramBlockAst = functionDefinitionAst.Body.ParamBlock;
+                return new List<ParameterAst>(functionDefinitionAst.Body.ParamBlock.Parameters).ToArray();
+            }
+
+            return null;
+        }
     }
 }

rules/UseSupportsShouldProcess.cs

@@ -65,7 +65,7 @@ private List<DiagnosticRecord> FindViolations()
                 int whatIfIndex, confirmIndex;
                 ParameterAst whatIfParamAst, confirmParamAst;
                 ParamBlockAst paramBlockAst;
-                ParameterAst[] parameterAsts = GetParameters(functionDefinitionAst, out paramBlockAst);
+                ParameterAst[] parameterAsts = functionDefinitionAst.GetParameterAsts(out paramBlockAst);
                 if (parameterAsts == null)
                 {
                     continue;
@@ -110,24 +110,6 @@ private List<DiagnosticRecord> FindViolations()
             return diagnosticRecords;
         }
 
-        private static ParameterAst[] GetParameters(
-            FunctionDefinitionAst functionDefinitionAst,
-            out ParamBlockAst paramBlockAst)
-        {
-            paramBlockAst = null;
-            if (functionDefinitionAst.Parameters != null)
-            {
-                return new List<ParameterAst>(functionDefinitionAst.Parameters).ToArray();
-            }
-            else if (functionDefinitionAst.Body.ParamBlock?.Parameters != null)
-            {
-                paramBlockAst = functionDefinitionAst.Body.ParamBlock;
-                return new List<ParameterAst>(functionDefinitionAst.Body.ParamBlock.Parameters).ToArray();
-            }
-
-            return null;
-        }
-
         private List<CorrectionExtent> GetCorrections(
             int whatIfIndex,
             int confirmIndex,