Add extension method to convert IScriptExtent to Range

Author: Kapil Borle

Engine/Extensions.cs

@@ -42,5 +42,17 @@ public static IScriptExtent Translate(this IScriptExtent extent, int lineDelta,
                     newEndColumnNumber,
                     extent.EndScriptPosition.Line));
         }
+
+        /// <summary>
+        /// Converts IScriptExtent to Range
+        /// </summary>
+        public static Range ToRange(this IScriptExtent extent)
+        {
+           return new Range(
+                extent.StartLineNumber,
+                extent.StartColumnNumber,
+                extent.EndLineNumber,
+                extent.EndColumnNumber);
+        }
     }
 }

rules/UseSupportsShouldProcess.cs

@@ -141,7 +141,6 @@ private List<CorrectionExtent> GetCorrections(
             {
                 if (whatIfIndex != -1)
                 {
-                    // TODO update method name to reflect its purpose.
                     correctionExtents.Add(GetCorrectionToRemoveParam(whatIfIndex, parameterAsts));
                 }
 
@@ -281,16 +280,11 @@ private static CorrectionExtent GetCorrectionToRemoveFuncParamDecl(
         }
 
         // doesn't seem right. The arguments should be of same type.
-        private CorrectionExtent Normalize(IScriptExtent referenceExtent, CorrectionExtent cextent)
+        private CorrectionExtent Normalize(
+            IScriptExtent referenceExtent,
+            CorrectionExtent correctionExtent)
         {
-            // TODO Add ToRange extension methods for this conversion
-            var refRange = new Range(
-                referenceExtent.StartLineNumber,
-                referenceExtent.StartColumnNumber,
-                referenceExtent.EndLineNumber,
-                referenceExtent.EndColumnNumber);
-
-            var shiftedRange = Range.Normalize(refRange, cextent);
+            var shiftedRange = Range.Normalize(referenceExtent.ToRange(), correctionExtent);
 
             // TODO Add a method to TextEdit class that takes in range and text
             // TODO Add a method to CorrectionExtent that takes in range and all other stuff
@@ -299,9 +293,9 @@ private CorrectionExtent Normalize(IScriptExtent referenceExtent, CorrectionExte
                  shiftedRange.End.Line,
                  shiftedRange.Start.Column,
                  shiftedRange.End.Column,
-                 cextent.Text,
-                 cextent.File,
-                 cextent.Description);
+                 correctionExtent.Text,
+                 correctionExtent.File,
+                 correctionExtent.Description);
         }
         private static bool TryGetCmdletBindingAttribute(
             ParamBlockAst paramBlockAst,