Localize error strings in Position class

Author: Kapil Borle

Engine/Position.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer
 {
@@ -10,12 +11,16 @@ public Position(int line, int column)
         {
             if (line < 1)
             {
-                throw new ArgumentException("line cannot be less than 1.", nameof(line));
+                throw new ArgumentException(
+                    String.Format(CultureInfo.CurrentCulture, Strings.PositionLineLessThanOne),
+                    nameof(line));
             }
 
             if (column < 1)
             {
-                throw new ArgumentException("line cannot be less than 1.", nameof(line));
+                throw new ArgumentException(
+                    String.Format(CultureInfo.CurrentCulture, Strings.PositionColumnLessThanOne),
+                    nameof(column));
             }
 
             Line = line;
@@ -38,24 +43,20 @@ public Position Shift(int lineDelta, int columnDelta)
             int newLine = Line;
             int newColumn = Column;
 
-            if (lineDelta != 0)
+            newLine += lineDelta;
+            if (newLine < 1)
             {
-                newLine += lineDelta;
-                if (newLine < 1)
-                {
-                    throw new ArgumentException("Invalid line delta. Resulting start line number must be greather than 1.");
-
-                }
+                throw new ArgumentException(
+                    String.Format(CultureInfo.CurrentCulture, Strings.PositionLineLessThanOne),
+                    nameof(lineDelta));
             }
 
-            if (columnDelta != 0)
+            newColumn += columnDelta;
+            if (newColumn < 1)
             {
-                newColumn += columnDelta;
-                if (newColumn < 1)
-                {
-                    throw new ArgumentException("Invalid column delta. Resulting start column number must be greather than 1.");
-
-                }
+                throw new ArgumentException(
+                    String.Format(CultureInfo.CurrentCulture, Strings.PositionColumnLessThanOne),
+                    nameof(columnDelta));
             }
 
             return new Position(newLine, newColumn);
@@ -75,7 +76,9 @@ public static Position Normalize(Position refPos, Position pos)
 
             if (pos < refPos)
             {
-                throw new ArgumentException("input should be less than that of the invoking object.");
+                throw new ArgumentException(String.Format(
+                    CultureInfo.CurrentCulture,
+                    Strings.PositionRefPosLessThanInputPos));
             }
 
             if (pos.Line == refPos.Line)

Engine/Strings.resx

@@ -309,4 +309,13 @@
   <data name="RangeRefPosShouldStartBeforeRangeStartPos" xml:space="preserve">
     <value>Reference Position should begin before start Position of Range.</value>
   </data>
+  <data name="PositionLineLessThanOne" xml:space="preserve">
+    <value>Line number cannot be less than 1.</value>
+  </data>
+  <data name="PositionColumnLessThanOne" xml:space="preserve">
+    <value>Column number cannot be less than 1.</value>
+  </data>
+  <data name="PositionRefPosLessThanInputPos" xml:space="preserve">
+    <value>Input position should be less than that of the invoking object.</value>
+  </data>
 </root>