Skip to content

Commit ce345cc

Browse files
author
Kapil Borle
committed
Add method to check whatif/confirm parameters
1 parent 3cd8b24 commit ce345cc

1 file changed

Lines changed: 18 additions & 7 deletions

File tree

rules/UseSupportsShouldProcess.cs

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -338,12 +338,7 @@ private static CorrectionExtent GetCorrectionExtent(
338338
if (paramIndex > 0)
339339
{
340340
var lp = parameterAsts[paramIndex - 1];
341-
if (!lp.Name.VariablePath.UserPath.Equals(
342-
"whatif",
343-
StringComparison.OrdinalIgnoreCase)
344-
&& !lp.Name.VariablePath.UserPath.Equals(
345-
"confirm",
346-
StringComparison.OrdinalIgnoreCase))
341+
if (!IsWhatIf(lp) && !IsConfirm(lp))
347342
{
348343
startLineNumber = lp.Extent.EndLineNumber;
349344
startColumnNumber = lp.Extent.EndColumnNumber;
@@ -428,7 +423,7 @@ private bool TryGetParameterAst(
428423
paramIndex = 0;
429424
foreach (var paramAst in parameterAsts)
430425
{
431-
if (paramAst.Name.VariablePath.UserPath.Equals(parameter, StringComparison.OrdinalIgnoreCase))
426+
if (IsParameter(paramAst, parameter))
432427
{
433428
return true;
434429
}
@@ -440,6 +435,22 @@ private bool TryGetParameterAst(
440435
return false;
441436
}
442437

438+
private static bool IsParameter(ParameterAst parameterAst, string parameterName)
439+
{
440+
return parameterAst.Name.VariablePath.UserPath.Equals(
441+
parameterName,
442+
StringComparison.OrdinalIgnoreCase);
443+
}
444+
private static bool IsWhatIf(ParameterAst parameterAst)
445+
{
446+
return IsParameter(parameterAst, "whatif");
447+
}
448+
449+
private static bool IsConfirm(ParameterAst parameterAst)
450+
{
451+
return IsParameter(parameterAst, "confirm");
452+
}
453+
443454
private string GetError(string functionName)
444455
{
445456
return string.Format(

0 commit comments

Comments
 (0)