Preserve exhausted formatter selections

Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>

Author: Copilot

Engine/Formatter.cs

@@ -54,6 +54,7 @@ public static string Format<TCmdlet>(
             ScriptBlockAst scriptAst = null;
             Token[] scriptTokens = null;
             bool skipParsing = false;
+            bool isRangeSpecified = range != null;
             foreach (var rule in ruleOrder)
             {
                 if (!settings.RuleArguments.ContainsKey(rule))
@@ -68,6 +69,10 @@ public static string Format<TCmdlet>(
                 text = ScriptAnalyzer.Instance.Fix(text, range, skipParsing, out Range updatedRange, out bool fixesWereApplied, ref scriptAst, ref scriptTokens, skipVariableAnalysis: true);
                 skipParsing = !fixesWereApplied;
                 range = updatedRange;
+                if (isRangeSpecified && range == null)
+                {
+                    break;
+                }
             }
 
             return text.ToString();

Engine/ScriptAnalyzer.cs

@@ -1594,7 +1594,7 @@ public EditableText Fix(EditableText text, Range range, bool skipParsing, out Ra
                 }
 
                 previousUnusedCorrections = unusedCorrections;
-            } while (previousUnusedCorrections > 0);
+            } while (previousUnusedCorrections > 0 && (isRangeNull || range != null));
 
             updatedRange = range;
             return text;
@@ -1743,19 +1743,15 @@ private static EditableText Fix(
                     var endLine = range.End.Line + lineDelta;
                     if (correction.Lines.Length == 0 && endLine < range.Start.Line)
                     {
-                        if (text.LineCount == 0)
-                        {
-                            range = null;
-                        }
-                        else
-                        {
-                            endLine = Math.Min(Math.Max(endLine, 1), text.LineCount);
-                            var endColumn = Math.Min(
-                                Math.Max(range.End.Column + columnDelta, 1),
-                                text.Lines[endLine - 1].Length + 1);
-                            var end = new Position(endLine, endColumn);
-                            range = new Range(end, end);
-                        }
+                        range = null;
+                    }
+                    else if (correction.Lines.Length == 0
+                        && lineDelta < 0
+                        && correction.EndLineNumber == range.End.Line)
+                    {
+                        range = new Range(
+                            range.Start,
+                            new Position(endLine, text.Lines[endLine - 1].Length + 1));
                     }
                     else
                     {

Tests/Engine/InvokeFormatter.tests.ps1

@@ -105,9 +105,10 @@ function foo {
 
             $text.ToString() | Should -Be "first`nlast"
             $arguments[3].End.Line | Should -Be 1
+            $arguments[3].End.Column | Should -Be 6
         }
 
-        It "Should collapse the range when an edit deletes all selected lines" {
+        It "Should exhaust the range when an edit deletes all selected lines" {
             $text = New-Object -TypeName "Microsoft.Windows.PowerShell.ScriptAnalyzer.EditableText" -ArgumentList "first`nlast"
             $correctionType = "Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent" -as [type]
             $correction = [Activator]::CreateInstance(
@@ -127,10 +128,8 @@ function foo {
                 [Reflection.BindingFlags]'NonPublic, Static')
 
             $fixMethod.Invoke($null, $arguments) | Out-Null
-
             $text.ToString() | Should -Be "first"
-            $arguments[3].Start.Line | Should -Be 1
-            $arguments[3].End.Line | Should -Be 1
+            $arguments[3] | Should -BeNullOrEmpty
         }
 
         It "Should apply all corrections when earlier fixes expand the selected line" {