Map symbol types to LSP better

Author: andyleejordan

src/PowerShellEditorServices/Services/Symbols/SymbolType.cs

@@ -94,9 +94,10 @@ internal static SymbolKind GetSymbolKind(SymbolType symbolType)
                 SymbolType.Method => SymbolKind.Method,
                 SymbolType.Property => SymbolKind.Property,
                 SymbolType.EnumMember => SymbolKind.EnumMember,
-                SymbolType.Variable => SymbolKind.Variable,
-                // TODO: More delicately handle the other symbol types.
-                _ => SymbolKind.Variable,
+                SymbolType.Variable or SymbolType.Parameter => SymbolKind.Variable,
+                SymbolType.HashtableKey => SymbolKind.Key,
+                SymbolType.Type => SymbolKind.TypeParameter,
+                SymbolType.Unknown or _ => SymbolKind.Object,
             };
         }
     }

src/PowerShellEditorServices/Services/Symbols/Visitors/SymbolVisitor.cs

@@ -15,6 +15,7 @@ namespace Microsoft.PowerShell.EditorServices.Services.Symbols;
 /// The goal of this is to be our one and only visitor, which parses a file when necessary
 /// performing Action, which takes a SymbolReference (that this visitor creates) and returns an
 /// AstVisitAction. In this way, all our symbols are created with the same initialization logic.
+/// TODO: Visit hashtable keys, constants, arrays, namespaces, interfaces, operators, etc.
 /// </summary>
 internal sealed class SymbolVisitor : AstVisitor2
 {