Fix ESLint

Author: andyleejordan

.eslintrc.json

@@ -33,42 +33,28 @@
       "error",
       "always"
     ],
-    "@typescript-eslint/explicit-function-return-type": [
-      "error"
-    ],
+    "@typescript-eslint/explicit-function-return-type": "error",
+    "@typescript-eslint/no-empty-object-type": "off",
     "@typescript-eslint/no-floating-promises": [
       "error",
       {
         "ignoreVoid": true
       }
     ],
-    "@typescript-eslint/no-non-null-assertion": [
-      "off"
-    ],
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "@typescript-eslint/no-require-imports": "off",
     "@typescript-eslint/no-unused-vars": [
       "error",
       {
         "argsIgnorePattern": "^_"
       }
     ],
-    "@typescript-eslint/no-unsafe-argument": [
-      "off"
-    ],
-    "@typescript-eslint/no-unsafe-assignment": [
-      "off"
-    ],
-    "@typescript-eslint/no-unsafe-call": [
-      "off"
-    ],
-    "@typescript-eslint/no-unsafe-member-access": [
-      "off"
-    ],
-    "@typescript-eslint/no-unsafe-return": [
-      "off"
-    ],
-    "@typescript-eslint/restrict-template-expressions": [
-      "off"
-    ],
+    "@typescript-eslint/no-unsafe-argument": "off",
+    "@typescript-eslint/no-unsafe-assignment": "off",
+    "@typescript-eslint/no-unsafe-call": "off",
+    "@typescript-eslint/no-unsafe-member-access": "off",
+    "@typescript-eslint/no-unsafe-return": "off",
+    "@typescript-eslint/restrict-template-expressions": "off",
     "@typescript-eslint/prefer-nullish-coalescing": [
       "error",
       {

package-lock.json

@@ -96,8 +96,8 @@
     "@types/ungap__structured-clone": "^1.2.0",
     "@types/uuid": "^9.0.8",
     "@types/vscode": "~1.82.0",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.5.0",
+    "@typescript-eslint/parser": "^8.5.0",
     "@ungap/structured-clone": "^1.2.0",
     "@vscode/debugprotocol": "^1.67.0",
     "@vscode/test-electron": "^2.4.1",

package.json

@@ -73,7 +73,7 @@ async function showInner(
 }
 
 function getItemIndex(items: ICheckboxQuickPickItem[], itemLabel: string): number {
-    const trimmedLabel = itemLabel.substr(itemLabel.indexOf("]") + 2);
+    const trimmedLabel = itemLabel.substring(itemLabel.indexOf("]") + 2);
     return items.findIndex((item) => item.label === trimmedLabel);
 }
 

src/controls/checkboxQuickPick.ts

@@ -32,7 +32,7 @@ export class CodeActionsFeature implements vscode.Disposable {
         }
 
         if (ruleId.startsWith("PS")) {
-            ruleId = ruleId.substr(2);
+            ruleId = ruleId.substring(2);
         }
 
         await vscode.commands.executeCommand("vscode.open", vscode.Uri.parse(pssaDocBaseURL + ruleId));