Skip to content

Commit f40f596

Browse files
committed
clean up and trim
1 parent dd1c1c3 commit f40f596

1 file changed

Lines changed: 9 additions & 27 deletions

File tree

CONTRIBUTING.md

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -19,43 +19,25 @@ Create your own fork of this repo that you will make your changes on.
1919

2020
## Creating your feature
2121

22-
Always base your changes off the `main` branch, it is the most up to date.
22+
Always base your changes off the `main` branch unless otherwise asked.
2323

2424
## Pull Request
2525

26-
Once the feature is tested and ready, open a pull request to the `main` branch.
26+
All pull requests must:
2727

28-
Please ensure your tests are passing in your local environment and any new
29-
features are have appropriate tests added. Untested code will not be approved.
28+
- Pass all linting and formatting checks
29+
- Have tests that cover all branches of the added feature
30+
- If the PR is a bug fix there must be a test that duplicates the bug, proving
31+
it is fixed
3032

3133
## Code Style
3234

3335
Follow the patterns seen in the code. Walk where others have walked.
3436

35-
The majority of code style nits will be met simply by passing `pre-commit`
36-
checks prior to submitting a pull request.
37+
The majority of code style nits will be met when passing `pre-commit` checks
38+
prior to submitting a pull request.
3739

38-
- ### Do
39-
40-
- snake_case modules, variables, methods, and functions
41-
- PascalCase classes
42-
- Type-hint function/method signatures
43-
- Use verbs for getters/setters (`get_`, `fetch_`, `pull_`, `save_`, `put_`)
44-
- Use singular form for objects
45-
- Use plural form for lists/sequences
46-
47-
- ### Do Not
48-
49-
- Fight `black` formatting
50-
51-
- ### Comments
52-
53-
- Keep comments short and to the point
54-
- Let code explain "what" and comments explain "why"
55-
- All modules, functions, class, and methods must have a doc-string
56-
- Doc-strings are optional in tests when the test name explains "what"
57-
58-
- ### Tests
40+
## Tests
5941

6042
- Smaller tests are easier to work with
6143
- Mock at a minimum

0 commit comments

Comments
 (0)