Skip to content

Commit 69cbfb8

Browse files
committed
Do not make use of NPM token anymore
1 parent 64a1ae9 commit 69cbfb8

2 files changed

Lines changed: 20 additions & 22 deletions

File tree

.github/workflows/prep-release.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
1-
name: "Step 1: Prep Release"
1+
name: 'Step 1: Prep Release'
22
on:
33
workflow_dispatch:
44
inputs:
55
version_spec:
6-
description: "New Version Specifier"
7-
default: "next"
6+
description: 'New Version Specifier'
7+
default: 'next'
88
required: false
99
branch:
10-
description: "The branch to target"
10+
description: 'The branch to target'
1111
required: false
1212
post_version_spec:
13-
description: "Post Version Specifier"
13+
description: 'Post Version Specifier'
1414
required: false
15-
# silent:
16-
# description: "Set a placeholder in the changelog and don't publish the release."
17-
# required: false
18-
# type: boolean
15+
silent:
16+
description: "Set a placeholder in the changelog and don't publish the release."
17+
required: false
18+
type: boolean
1919
since:
20-
description: "Use PRs with activity since this date or git reference"
20+
description: 'Use PRs with activity since this date or git reference'
2121
required: false
2222
since_last_stable:
23-
description: "Use PRs with activity since the last stable git tag"
23+
description: 'Use PRs with activity since the last stable git tag'
2424
required: false
2525
type: boolean
2626
jobs:
@@ -37,12 +37,12 @@ jobs:
3737
with:
3838
token: ${{ secrets.GITHUB_TOKEN }}
3939
version_spec: ${{ github.event.inputs.version_spec }}
40-
# silent: ${{ github.event.inputs.silent }}
40+
silent: ${{ github.event.inputs.silent }}
4141
post_version_spec: ${{ github.event.inputs.post_version_spec }}
4242
branch: ${{ github.event.inputs.branch }}
4343
since: ${{ github.event.inputs.since }}
4444
since_last_stable: ${{ github.event.inputs.since_last_stable }}
4545

46-
- name: "** Next Step **"
46+
- name: '** Next Step **'
4747
run: |
4848
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"

.github/workflows/publish-release.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
name: "Step 2: Publish Release"
1+
name: 'Step 2: Publish Release'
22
on:
33
workflow_dispatch:
44
inputs:
55
branch:
6-
description: "The target branch"
6+
description: 'The target branch'
77
required: false
88
release_url:
9-
description: "The URL of the draft GitHub release"
9+
description: 'The URL of the draft GitHub release'
1010
required: false
1111
steps_to_skip:
12-
description: "Comma separated list of steps to skip"
12+
description: 'Comma separated list of steps to skip'
1313
required: false
1414

1515
jobs:
@@ -21,7 +21,7 @@ jobs:
2121
steps:
2222
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
2323

24-
- uses: actions/create-github-app-token@v1
24+
- uses: actions/create-github-app-token@v2
2525
id: app-token
2626
with:
2727
app-id: ${{ vars.APP_ID }}
@@ -38,20 +38,18 @@ jobs:
3838

3939
- name: Finalize Release
4040
id: finalize-release
41-
env:
42-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
4341
uses: jupyter-server/jupyter_releaser/.github/actions/finalize-release@v2
4442
with:
4543
token: ${{ steps.app-token.outputs.token }}
4644
release_url: ${{ steps.populate-release.outputs.release_url }}
4745

48-
- name: "** Next Step **"
46+
- name: '** Next Step **'
4947
if: ${{ success() }}
5048
run: |
5149
echo "Verify the final release"
5250
echo ${{ steps.finalize-release.outputs.release_url }}
5351
54-
- name: "** Failure Message **"
52+
- name: '** Failure Message **'
5553
if: ${{ failure() }}
5654
run: |
5755
echo "Failed to Publish the Draft Release Url:"

0 commit comments

Comments
 (0)