Skip to content

Commit 121e201

Browse files
davidbrochartgjmooney
authored andcommitted
Apply suggestions
1 parent a178fc6 commit 121e201

1 file changed

Lines changed: 16 additions & 17 deletions

File tree

tests/test_comm_awareness.py

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import pytest
44
from pycrdt import Awareness, Doc, YMessageType, create_awareness_message
5+
from ypywidgets.comm import CommWidget
56

67
pytestmark = pytest.mark.anyio
78

@@ -12,34 +13,32 @@ async def test_comm_provider_applies_awareness_frame(synced_widgets, context):
1213
remote_awareness = Awareness(Doc())
1314
remote_awareness.set_local_state({"role": "remote"})
1415
payload = remote_awareness.encode_awareness_update([remote_awareness.client_id])
15-
frame = create_awareness_message(payload)
16+
message = create_awareness_message(payload)
1617

17-
assert frame[0] == YMessageType.AWARENESS
18+
assert message[0] == YMessageType.AWARENESS
1819

19-
local_widget._comm_provider._receive({"buffers": [frame]})
20+
local_widget._comm_provider._receive({"buffers": [message]})
2021

2122
remote_state = local_widget.awareness.states.get(remote_awareness.client_id)
2223
assert remote_state is not None
2324
assert remote_state.get("role") == "remote"
2425

2526

26-
async def test_comm_widget_exposes_provider_awareness(synced_widgets, context):
27-
async with context:
28-
widget = await synced_widgets.get_local_widget()
29-
assert widget.awareness is widget._comm_provider.awareness
27+
async def test_comm_widget_exposes_provider_awareness():
28+
widget = CommWidget()
29+
assert widget.awareness is widget._comm_provider.awareness
3030

3131

3232
async def test_comm_widget_awareness_observe_and_unobserve(synced_widgets, context):
33-
async with context:
34-
widget = await synced_widgets.get_local_widget()
33+
widget = CommWidget()
3534

36-
events: list[str] = []
37-
sub_id = widget.awareness.observe(lambda topic, _: events.append(topic))
35+
events: list[str] = []
36+
sub_id = widget.awareness.observe(lambda topic, _: events.append(topic))
3837

39-
widget.awareness.set_local_state({"ping": 1})
40-
assert events
38+
widget.awareness.set_local_state({"ping": 1})
39+
assert events
4140

42-
widget.awareness.unobserve(sub_id)
43-
events.clear()
44-
widget.awareness.set_local_state({"ping": 2})
45-
assert events == []
41+
widget.awareness.unobserve(sub_id)
42+
events.clear()
43+
widget.awareness.set_local_state({"ping": 2})
44+
assert events == []

0 commit comments

Comments
 (0)