From 6d53263698b9e411f1785f71694a15f62aac47e5 Mon Sep 17 00:00:00 2001 From: Sander van Rossen Date: Sat, 24 Oct 2026 16:29:50 +0200 Subject: [PATCH 1/4] URP only: no render pipeline choice in the bug report, no unused HDRP define or built-in default material The bug report says Chisel needs URP instead of asking which pipeline is used; the core assembly's USING_URP and USING_HDRP defines were never used, and neither was SceneHandleMaterialManager.DefaultMaterial (a built-in material). --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++---------- Core/com.chisel.core.asmdef | 13 +------------ .../Visualization/SceneHandleMaterialManager.cs | 12 ------------ 3 files changed, 3 insertions(+), 34 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index a9af9718..22b80040 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -6,6 +6,8 @@ body: attributes: value: | Thanks for reporting a problem! A scene that shows it, or steps to make it happen, helps us fix it much faster. + + Chisel needs Unity 6.6 or newer and the Universal Render Pipeline (URP); other render pipelines aren't supported. - type: textarea id: what attributes: @@ -50,16 +52,6 @@ body: description: The version in the Package Manager, or the commit you installed. validations: required: true - - type: dropdown - id: pipeline - attributes: - label: Render pipeline - options: - - URP - - HDRP - - Built-in - validations: - required: true - type: input id: platform attributes: diff --git a/Core/com.chisel.core.asmdef b/Core/com.chisel.core.asmdef index fbc60db5..37a4b7a8 100644 --- a/Core/com.chisel.core.asmdef +++ b/Core/com.chisel.core.asmdef @@ -21,17 +21,6 @@ ], "autoReferenced": true, "defineConstraints": [], - "versionDefines": [ - { - "name": "com.unity.render-pipelines.universal", - "expression": "0.0.0", - "define": "USING_URP" - }, - { - "name": "com.unity.render-pipelines.high-definition", - "expression": "0.0.0", - "define": "USING_HDRP" - } - ], + "versionDefines": [], "noEngineReferences": false } \ No newline at end of file diff --git a/Editor/SceneView/Visualization/SceneHandleMaterialManager.cs b/Editor/SceneView/Visualization/SceneHandleMaterialManager.cs index 46b68942..8dbf01f0 100644 --- a/Editor/SceneView/Visualization/SceneHandleMaterialManager.cs +++ b/Editor/SceneView/Visualization/SceneHandleMaterialManager.cs @@ -24,18 +24,6 @@ static void ShaderInit() s_LineAlphaMultiplierId = Shader.PropertyToID("_alphaMultiplier"); } - static Material s_DefaultMaterial; - public static Material DefaultMaterial - { - get - { - // TODO: make this work with HDRP - if (!s_DefaultMaterial) - s_DefaultMaterial = AssetDatabase.GetBuiltinExtraResource("Default-Diffuse.mat"); - return s_DefaultMaterial; - } - } - public static void InitGenericLineMaterial(Material genericLineMaterial) { if (!genericLineMaterial) From fd3bef8214aac67c3b802b76ede7adab02b8113a Mon Sep 17 00:00:00 2001 From: Sander van Rossen Date: Sat, 24 Oct 2026 16:31:11 +0200 Subject: [PATCH 2/4] Don't use UnityEngine.UI in the editor: the package doesn't depend on uGUI ChiselGlobal.cs had an unused using UnityEngine.UI, so the package didn't compile in a project without com.unity.ugui. --- Editor/SceneView/Overlays/ChiselGlobal.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/Editor/SceneView/Overlays/ChiselGlobal.cs b/Editor/SceneView/Overlays/ChiselGlobal.cs index ea263556..2855c7db 100644 --- a/Editor/SceneView/Overlays/ChiselGlobal.cs +++ b/Editor/SceneView/Overlays/ChiselGlobal.cs @@ -7,7 +7,6 @@ using UnityEditor.Overlays; using UnityEditor.Toolbars; using UnityEngine; -using UnityEngine.UI; // Just a misc. collections of buttons we don't have a more sensible place for namespace Chisel.Editors From f4e50689b4811bc524fe920aa2901e3d85501c1e Mon Sep 17 00:00:00 2001 From: Sander van Rossen Date: Sat, 24 Oct 2026 16:31:30 +0200 Subject: [PATCH 3/4] Installation: what to do when it fails (long paths on Windows, git missing) --- INSTALLATION.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/INSTALLATION.md b/INSTALLATION.md index 72f7a8e6..938a3f07 100644 --- a/INSTALLATION.md +++ b/INSTALLATION.md @@ -24,4 +24,12 @@ needs to be installed and on your path. The first time you start up it might take some time, because Unity Burst compiles a lot of code. This should only happen once. +### If the installation fails + +* **"Filename too long"** (Windows): git can't write the dependencies inside a deep project folder. Allow long + paths in git once, with `git config --global core.longpaths true`, or move the project to a shorter path, then + install again. +* **"Cannot checkout repository"**: make sure git is installed and that `git` works in a command prompt; Unity uses + it to download Chisel and its dependencies. + Then see [Getting Started](GETTING_STARTED.md). From f14e4fbd01ddafc5822fc48d7e53bea44416ae59 Mon Sep 17 00:00:00 2001 From: Sander van Rossen Date: Sat, 24 Oct 2026 16:34:37 +0200 Subject: [PATCH 4/4] No Burst warnings on install: take the lengths before calling the discarded logger Passing NativeList.Length straight into the [BurstDiscard] LogInconsistentVertexStreams made Burst warn (BC1371) that the calls were discarded. --- Core/2.Processing/Jobs/JobData/ChiselBrushRenderBuffer.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Core/2.Processing/Jobs/JobData/ChiselBrushRenderBuffer.cs b/Core/2.Processing/Jobs/JobData/ChiselBrushRenderBuffer.cs index 818e88c7..ca3e097e 100644 --- a/Core/2.Processing/Jobs/JobData/ChiselBrushRenderBuffer.cs +++ b/Core/2.Processing/Jobs/JobData/ChiselBrushRenderBuffer.cs @@ -186,10 +186,10 @@ public void Construct(BlobBuilder builder, SurfaceDestinationParameters destinationParameters, SurfaceOutputFlags outputFlags) { - if (colliderVertices.Length != renderVertices.Length || - colliderVertices.Length != selectVertices.Length) + int colliderCount = colliderVertices.Length, selectCount = selectVertices.Length, renderCount = renderVertices.Length, indexCount = indices.Length; + if (colliderCount != renderCount || colliderCount != selectCount) { - LogInconsistentVertexStreams(surfaceIndex, colliderVertices.Length, selectVertices.Length, renderVertices.Length, indices.Length); + LogInconsistentVertexStreams(surfaceIndex, colliderCount, selectCount, renderCount, indexCount); this.surfaceIndex = surfaceIndex; this.baseSurfaceIndex = baseSurfaceIndex;