Move assemble_text_with_context to context_bridge.cc to fix link order

The function was defined in source/text.cpp (guarded by SPIRV_RUST_TARGET_ENV)
and called by lib.rs.cc in spirv-tools-ffi. This created a circular link
dependency: spirv-tools-ffi needed the symbol from SPIRV-Tools, but
SPIRV-Tools linked spirv-tools-ffi. On Linux, the single-pass linker
couldn't resolve this.

Fix by moving the function to context_bridge.cc (part of spirv-tools-ffi)
and using the public API spvTextToBinaryWithOptions instead of the internal
AssembleTextWithDiagnostics function.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: LegNeato

rust/spirv-tools-ffi/src/context_bridge.cc

@@ -63,6 +63,37 @@ void dispatch_context_message(std::uintptr_t context_ptr, std::uint32_t level,
                     ToSpvPosition(position), message_storage.c_str());
 }
 
+AssembleResult assemble_text_with_context(std::size_t context_ptr,
+                                          rust::Slice<const std::uint8_t> text,
+                                          std::uint32_t options) {
+  AssembleResult result{false, ::rust::Vec<std::uint32_t>()};
+  auto* context = reinterpret_cast<spv_context>(context_ptr);
+  if (context == nullptr) {
+    return result;
+  }
+
+  spv_binary binary = nullptr;
+  spv_diagnostic diagnostic = nullptr;
+  const char* text_ptr = reinterpret_cast<const char*>(text.data());
+  const spv_result_t status =
+      spvTextToBinaryWithOptions(context, text_ptr, text.size(), options,
+                                 &binary, &diagnostic);
+  if (diagnostic) {
+    spvDiagnosticDestroy(diagnostic);
+  }
+
+  if (status == SPV_SUCCESS && binary != nullptr) {
+    result.success = true;
+    result.binary.reserve(binary->wordCount);
+    for (size_t i = 0; i < binary->wordCount; ++i) {
+      result.binary.push_back(binary->code[i]);
+    }
+    spvBinaryDestroy(binary);
+  }
+
+  return result;
+}
+
 ValidateResult validate_binary_with_options(
     std::uint32_t env, rust::Slice<const std::uint32_t> words,
     const ValidatorOptions& options) {

source/text.cpp

@@ -1071,43 +1071,6 @@ spv_result_t spvTextToBinaryWithOptions(const spv_const_context context,
                                      sanitized_options, pBinary, pDiagnostic);
 }
 
-#if defined(SPIRV_RUST_TARGET_ENV)
-namespace spvtools::ffi {
-
-AssembleResult assemble_text_with_context(std::size_t context_ptr,
-                                          ::rust::Slice<const std::uint8_t> text,
-                                          std::uint32_t options) {
-  AssembleResult result{
-      /*success=*/false,
-      /*binary=*/{}};
-
-  if (context_ptr == 0 || text.data() == nullptr) {
-    return result;
-  }
-
-  auto* context = reinterpret_cast<spv_const_context>(context_ptr);
-  if (!context) {
-    return result;
-  }
-
-  spv_binary binary = nullptr;
-  spv_result_t status = AssembleTextWithDiagnostics(
-      context, reinterpret_cast<const char*>(text.data()), text.size(), options,
-      &binary, nullptr);
-  if (status == SPV_SUCCESS && binary != nullptr) {
-    result.success = true;
-    result.binary.reserve(binary->wordCount);
-    for (std::size_t i = 0; i < binary->wordCount; ++i) {
-      result.binary.push_back(binary->code[i]);
-    }
-  }
-  spvBinaryDestroy(binary);
-  return result;
-}
-
-}  // namespace spvtools::ffi
-#endif
-
 void spvTextDestroy(spv_text text) {
   if (text) {
     if (text->str) delete[] text->str;