Remov no-longer used code

Cleanup

Author: SaschaWillems

base/VulkanInitializers.hpp

@@ -160,9 +160,7 @@ namespace vks
 
 		inline VkSubmitInfo submitInfo()
 		{
-			VkSubmitInfo submitInfo {};
-			submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
-			return submitInfo;
+			return { .sType = VK_STRUCTURE_TYPE_SUBMIT_INFO };
 		}
 
 		inline VkViewport viewport(

base/VulkanUIOverlay.cpp

@@ -338,7 +338,6 @@ namespace vks
 			buffers[currentBuffer].vertexBuffer.destroy();
 			VK_CHECK_RESULT(device->createBuffer(VK_BUFFER_USAGE_VERTEX_BUFFER_BIT, VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT, &buffers[currentBuffer].vertexBuffer, vertexBufferSize));
 			buffers[currentBuffer].vertexCount = imDrawData->TotalVtxCount;
-			//buffers[currentBuffer].vertexBuffer.unmap();
 			buffers[currentBuffer].vertexBuffer.map();
 		}
 

examples/computecloth/computecloth.cpp

@@ -112,7 +112,6 @@ class VulkanExample : public VulkanExampleBase
 		camera.setPerspective(60.0f, (float)width / (float)height, 0.1f, 512.0f);
 		camera.setRotation(glm::vec3(-30.0f, -45.0f, 0.0f));
 		camera.setTranslation(glm::vec3(0.0f, 0.0f, -5.0f));
-		settings.overlay = false;
 	}
 
 	~VulkanExample()
@@ -628,7 +627,7 @@ class VulkanExample : public VulkanExampleBase
 		buildGraphicsCommandBuffer();
 
 		VkPipelineStageFlags waitDstStageMask[2] = {
-			submitPipelineStages, VK_PIPELINE_STAGE_VERTEX_INPUT_BIT
+			VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_PIPELINE_STAGE_VERTEX_INPUT_BIT
 		};
 		VkSemaphore waitSemaphores[2] = {
 			semaphores.presentComplete, compute.semaphores[currentBuffer].complete
@@ -637,6 +636,7 @@ class VulkanExample : public VulkanExampleBase
 			semaphores.renderComplete, compute.semaphores[currentBuffer].ready
 		};
 
+		VkSubmitInfo submitInfo = vks::initializers::submitInfo();
 		submitInfo.waitSemaphoreCount = 2;
 		submitInfo.pWaitDstStageMask = waitDstStageMask;
 		submitInfo.pWaitSemaphores = waitSemaphores;

examples/dynamicrendering/dynamicrendering.cpp

@@ -201,7 +201,6 @@ class VulkanExample : public VulkanExampleBase
 		prepareUniformBuffers();
 		setupDescriptors();
 		preparePipelines();
-		buildCommandBuffers();
 		prepared = true;
 	}
 

examples/dynamicrenderingmultisampling/dynamicrenderingmultisampling.cpp

@@ -283,7 +283,6 @@ class VulkanExample : public VulkanExampleBase
 		prepareUniformBuffers();
 		setupDescriptors();
 		preparePipelines();
-		buildCommandBuffers();
 		prepared = true;
 	}
 

examples/imgui/main.cpp

@@ -17,8 +17,8 @@ class ImGUI {
 private:
 	// Vulkan resources for rendering the UI
 	struct Buffers {
-		vks::Buffer vertexBuffer;
-		vks::Buffer indexBuffer;
+		vks::Buffer vertexBuffer{ VK_NULL_HANDLE };
+		vks::Buffer indexBuffer{ VK_NULL_HANDLE };
 		int32_t vertexCount = 0;
 		int32_t indexCount = 0;
 	};

examples/indirectdraw/README.md

@@ -75,12 +75,12 @@ To use a buffer for indirect draw commands you need to specify the ```VK_BUFFER_
 ### Rendering
 If the [`multiDrawIndirect`](http://vulkan.gpuinfo.org/listreports.php?feature=multiDrawIndirect) is supported, we can issue all indirect draws with one single draw call:
 ```cpp
-void buildCommandBuffers()
+void buildCommandBuffer()
 {
   ...
   for (int32_t i = 0; i < drawCmdBuffers.size(); ++i)
   {
-    vkCmdDrawIndexedIndirect(drawCmdBuffers[i], indirectCommandsBuffer.buffer, 0, indirectDrawCount, sizeof(VkDrawIndexedIndirectCommand));
+    vkCmdDrawIndexedIndirect(cmdBuffer, indirectCommandsBuffer.buffer, 0, indirectDrawCount, sizeof(VkDrawIndexedIndirectCommand));
   }
 }
 ```
@@ -92,7 +92,7 @@ for (auto indirectCmd : indirectCommands)
   {
     for (uint32_t j = 0; j < indirectCmd.instanceCount; j++)
     {
-      vkCmdDrawIndexed(drawCmdBuffers[i], indirectCmd.indexCount, 1, indirectCmd.firstIndex, 0, indirectCmd.firstInstance + j);
+      vkCmdDrawIndexed(cmdBuffer, indirectCmd.indexCount, 1, indirectCmd.firstIndex, 0, indirectCmd.firstInstance + j);
     }
   }
 ```
@@ -101,7 +101,7 @@ If the GPU does not support ```multiDrawIndirect``` we have to issue the indirec
 ```cpp
 for (auto j = 0; j < indirectCommands.size(); j++)
 {
-  vkCmdDrawIndexedIndirect(drawCmdBuffers[i], indirectCommandsBuffer.buffer, j * sizeof(VkDrawIndexedIndirectCommand), 1, sizeof(VkDrawIndexedIndirectCommand));
+  vkCmdDrawIndexedIndirect(cmdBuffer, indirectCommandsBuffer.buffer, j * sizeof(VkDrawIndexedIndirectCommand), 1, sizeof(VkDrawIndexedIndirectCommand));
 }
 ```
 

examples/oit/oit.cpp

@@ -432,7 +432,6 @@ class VulkanExample : public VulkanExampleBase
 		prepareGeometryPass();
 		setupDescriptors();
 		preparePipelines();
-		buildCommandBuffers();
 		prepared = true;
 	}
 
@@ -570,7 +569,6 @@ class VulkanExample : public VulkanExampleBase
 		vkResetDescriptorPool(device, descriptorPool, 0);
 		updateDescriptors();
 		resized = false;
-		buildCommandBuffers();
 	}
 
 	void destroyGeometryPass()

examples/parallaxmapping/parallaxmapping.cpp

@@ -115,7 +115,6 @@ class VulkanExample : public VulkanExampleBase
 		VkDescriptorSetLayoutCreateInfo descriptorLayout = vks::initializers::descriptorSetLayoutCreateInfo(setLayoutBindings);
 		VK_CHECK_RESULT(vkCreateDescriptorSetLayout(device, &descriptorLayout, nullptr, &descriptorSetLayout));
 
-		// Set
 		// Sets per frame, just like the buffers themselves
 		// Images do not need to be duplicated per frame, we reuse the same one for each frame
 		VkDescriptorSetAllocateInfo allocInfo = vks::initializers::descriptorSetAllocateInfo(descriptorPool, &descriptorSetLayout, 1);

examples/pushconstants/pushconstants.cpp

@@ -178,7 +178,6 @@ class VulkanExample : public VulkanExampleBase
 		prepareUniformBuffers();
 		setupDescriptors();
 		preparePipelines();
-		buildCommandBuffers();
 		prepared = true;
 	}