Skip to content

Commit 000b97a

Browse files
Uwe Kleine-Königthierryreding
authored andcommitted
pwm: stm32: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
1 parent e13cec3 commit 000b97a

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/pwm/pwm-stm32.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ static int stm32_pwm_probe(struct platform_device *pdev)
642642
return 0;
643643
}
644644

645-
static int stm32_pwm_remove(struct platform_device *pdev)
645+
static void stm32_pwm_remove(struct platform_device *pdev)
646646
{
647647
struct stm32_pwm *priv = platform_get_drvdata(pdev);
648648
unsigned int i;
@@ -651,8 +651,6 @@ static int stm32_pwm_remove(struct platform_device *pdev)
651651
pwm_disable(&priv->chip.pwms[i]);
652652

653653
pwmchip_remove(&priv->chip);
654-
655-
return 0;
656654
}
657655

658656
static int __maybe_unused stm32_pwm_suspend(struct device *dev)
@@ -699,7 +697,7 @@ MODULE_DEVICE_TABLE(of, stm32_pwm_of_match);
699697

700698
static struct platform_driver stm32_pwm_driver = {
701699
.probe = stm32_pwm_probe,
702-
.remove = stm32_pwm_remove,
700+
.remove_new = stm32_pwm_remove,
703701
.driver = {
704702
.name = "stm32-pwm",
705703
.of_match_table = stm32_pwm_of_match,

0 commit comments

Comments
 (0)