Skip to content

Commit 008a746

Browse files
mjguzikbrauner
authored andcommitted
fs: use wq_has_sleeper() in end_dir_add()
The routine is used a lot, while the wakeup almost never has anyone to deal with. wake_up_all() takes an irq-protected spinlock, wq_has_sleeper() "only" contains a full fence -- not free by any means, but still cheaper. Sample result tracing waiters using a custom probe during -j 20 kernel build (0 - no waiters, 1 - waiters): @[ wakeprobe+5 __wake_up_common+63 __wake_up+54 __d_add+234 d_splice_alias+146 ext4_lookup+439 path_openat+1746 do_filp_open+195 do_sys_openat2+153 __x64_sys_openat+86 do_syscall_64+82 entry_SYSCALL_64_after_hwframe+118 ]: [0, 1) 13999 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| [1, ...) 1 | | Only 1 call out of 14000 with this backtrace had waiters. Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Link: https://lore.kernel.org/r/20250316232421.1642758-1-mjguzik@gmail.com Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 514b687 commit 008a746

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

fs/dcache.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2480,7 +2480,8 @@ static inline void end_dir_add(struct inode *dir, unsigned int n,
24802480
{
24812481
smp_store_release(&dir->i_dir_seq, n + 2);
24822482
preempt_enable_nested();
2483-
wake_up_all(d_wait);
2483+
if (wq_has_sleeper(d_wait))
2484+
wake_up_all(d_wait);
24842485
}
24852486

24862487
static void d_wait_lookup(struct dentry *dentry)

0 commit comments

Comments
 (0)