hwmon: (nzxt-smart2) make array detect_fans_report static const

ColinIanKing · groeck · commit 00f5117c5f78 · 2022-01-09T17:10:58.000-08:00
Don't populate the read-only array detect_fans_report on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20220109194558.45811-1-colin.i.king@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
@@ -583,7 +583,7 @@ static int set_update_interval(struct drvdata *drvdata, long val)
 static int init_device(struct drvdata *drvdata, long update_interval)
 {
 	int ret;
-	u8 detect_fans_report[] = {
+	static const u8 detect_fans_report[] = {
 		OUTPUT_REPORT_ID_INIT_COMMAND,
 		INIT_COMMAND_DETECT_FANS,
 	};

Original file line number	Diff line number	Diff line change
`@@ -583,7 +583,7 @@ static int set_update_interval(struct drvdata *drvdata, long val)`
`583`	`583`	`static int init_device(struct drvdata *drvdata, long update_interval)`
`584`	`584`	`{`
`585`	`585`	`int ret;`
`586`		`- u8 detect_fans_report[] = {`
	`586`	`+ static const u8 detect_fans_report[] = {`
`587`	`587`	`OUTPUT_REPORT_ID_INIT_COMMAND,`
`588`	`588`	`INIT_COMMAND_DETECT_FANS,`
`589`	`589`	`};`