futex/requeue: Remove unnecessary ‘NULL’ initialization from futex_proxy_trylock_atomic()

Li zeming · ingomolnar · commit 01a99a750a4f · 2023-10-04T18:04:47.000+02:00
'top_waiter' is assigned unconditionally before first use, so it does not need an initialization. [ mingo: Created legible changelog. ] Signed-off-by: Li zeming <zeming@nfschina.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20230725195047.3106-1-zeming@nfschina.com
diff --git a/kernel/futex/requeue.c b/kernel/futex/requeue.c
@@ -269,7 +269,7 @@ futex_proxy_trylock_atomic(u32 __user *pifutex, struct futex_hash_bucket *hb1,
 			   union futex_key *key2, struct futex_pi_state **ps,
 			   struct task_struct **exiting, int set_waiters)
 {
-	struct futex_q *top_waiter = NULL;
+	struct futex_q *top_waiter;
 	u32 curval;
 	int ret;
 

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ futex_proxy_trylock_atomic(u32 __user pifutex, struct futex_hash_bucket hb1,`
`269`	`269`	`union futex_key key2, struct futex_pi_state *ps,`
`270`	`270`	`struct task_struct **exiting, int set_waiters)`
`271`	`271`	`{`
`272`		`- struct futex_q *top_waiter = NULL;`
	`272`	`+ struct futex_q *top_waiter;`
`273`	`273`	`u32 curval;`
`274`	`274`	`int ret;`
`275`	`275`