mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe()

Zhihao Cheng · JassiBrar · commit 01c59166b4a0 · 2021-06-26T11:40:32.000-05:00
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot &lt;hulkci@huawei.com&gt;
Signed-off-by: Zhihao Cheng &lt;chengzhihao1@huawei.com&gt;
Signed-off-by: Jassi Brar &lt;jaswinder.singh@linaro.org&gt;
diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
@@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
 	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
 	if (IS_ERR(mbox->regs)) {
 		ret = PTR_ERR(mbox->regs);
-		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
 		return ret;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)`
`157`	`157`	`mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);`
`158`	`158`	`if (IS_ERR(mbox->regs)) {`
`159`	`159`	`ret = PTR_ERR(mbox->regs);`
`160`		`- dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);`
`161`	`160`	`return ret;`
`162`	`161`	`}`
`163`	`162`