Skip to content

Commit 01f1269

Browse files
GustavoARSilvaJiri Kosina
authored andcommitted
HID: google: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows. Also, address the following sparse warnings: drivers/hid/hid-google-hammer.c:61:23: warning: using sizeof on a flexible structure Link: KSPP#174 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 9b57f45 commit 01f1269

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/hid/hid-google-hammer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ static int cbas_ec_query_base(struct cros_ec_device *ec_dev, bool get_state,
5858
struct cros_ec_command *msg;
5959
int ret;
6060

61-
msg = kzalloc(sizeof(*msg) + max(sizeof(u32), sizeof(*params)),
61+
msg = kzalloc(struct_size(msg, data, max(sizeof(u32), sizeof(*params))),
6262
GFP_KERNEL);
6363
if (!msg)
6464
return -ENOMEM;

0 commit comments

Comments
 (0)