Skip to content

Commit 02377e9

Browse files
committed
platform/x86: x86-android-tablets: Update Yoga Book HiDeep touchscreen comment
After recent i2c-hid-of changes, the i2c-hid-of driver could be used for the Yoga Book HiDeep touchscreen comment instead of the native hideep driver. Update the comment to reflect this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230416212841.311152-1-hdegoede@redhat.com
1 parent 3a133f7 commit 02377e9

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

  • drivers/platform/x86/x86-android-tablets

drivers/platform/x86/x86-android-tablets/lenovo.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,13 @@ static struct lp855x_platform_data lenovo_lp8557_pdata = {
4141
/* Lenovo Yoga Book X90F / X90L's Android factory img has everything hardcoded */
4242

4343
/*
44-
* The HiDeep IST940E touchscreen comes up in HID mode and could alternatively
45-
* be used in I2C-HID mode (I2C-HID descriptor reg 0x0020) if i2c-hid-of.c is
46-
* modified to use generic (non-OF) device-properties and thought to deal with
47-
* the reset GPIO. "hideep,force-native-protocol" resets it to native mode.
44+
* The HiDeep IST940E touchscreen comes up in I2C-HID mode. The native protocol
45+
* reports ABS_MT_PRESSURE and ABS_MT_TOUCH_MAJOR which are not reported in HID
46+
* mode, so using native mode is preferred.
47+
* It could alternatively be used in HID mode by changing the properties to:
48+
* PROPERTY_ENTRY_U32("hid-descr-addr", 0x0020),
49+
* PROPERTY_ENTRY_U32("post-reset-deassert-delay-ms", 120),
50+
* and changing board_info.type to "hid-over-i2c".
4851
*/
4952
static const struct property_entry lenovo_yb1_x90_hideep_ts_props[] = {
5053
PROPERTY_ENTRY_U32("touchscreen-size-x", 1200),

0 commit comments

Comments
 (0)