Skip to content

Commit 024a3ca

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: wm8505fb: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 3ab20cd commit 024a3ca

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/video/fbdev/wm8505fb.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ static int wm8505fb_probe(struct platform_device *pdev)
372372
return 0;
373373
}
374374

375-
static int wm8505fb_remove(struct platform_device *pdev)
375+
static void wm8505fb_remove(struct platform_device *pdev)
376376
{
377377
struct wm8505fb_info *fbi = platform_get_drvdata(pdev);
378378

@@ -382,8 +382,6 @@ static int wm8505fb_remove(struct platform_device *pdev)
382382

383383
if (fbi->fb.cmap.len)
384384
fb_dealloc_cmap(&fbi->fb.cmap);
385-
386-
return 0;
387385
}
388386

389387
static const struct of_device_id wmt_dt_ids[] = {
@@ -393,7 +391,7 @@ static const struct of_device_id wmt_dt_ids[] = {
393391

394392
static struct platform_driver wm8505fb_driver = {
395393
.probe = wm8505fb_probe,
396-
.remove = wm8505fb_remove,
394+
.remove_new = wm8505fb_remove,
397395
.driver = {
398396
.name = DRIVER_NAME,
399397
.of_match_table = wmt_dt_ids,

0 commit comments

Comments
 (0)