Skip to content

Commit 0284d4d

Browse files
wb-zjp846396jwrdegoede
authored andcommitted
platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative
Eliminate the follow smatch warnings: drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned 'value' is never less than zero. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 36560ef commit 0284d4d

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/platform/x86/samsung-laptop.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1121,8 +1121,6 @@ static void kbd_led_set(struct led_classdev *led_cdev,
11211121

11221122
if (value > samsung->kbd_led.max_brightness)
11231123
value = samsung->kbd_led.max_brightness;
1124-
else if (value < 0)
1125-
value = 0;
11261124

11271125
samsung->kbd_led_wk = value;
11281126
queue_work(samsung->led_workqueue, &samsung->kbd_led_work);

0 commit comments

Comments
 (0)