Skip to content

Commit 03286f9

Browse files
author
Lucas De Marchi
committed
drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
The comment on the parameter being 0 to avoid the read back doesn't apply as this is not a call to wa_add(), but rather to wa_write_clr_set(). So, this register is actually checked and it's according to the Bspec that the register is RW, not RO. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230630203509.1635216-7-lucas.demarchi@intel.com
1 parent 9a54a7c commit 03286f9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
666666
/* Wa_1604278689:icl,ehl */
667667
wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
668668
wa_write_clr_set(wal, IVB_FBC_RT_BASE_UPPER,
669-
0, /* write-only register; skip validation */
669+
0,
670670
0xFFFFFFFF);
671671

672672
/* Wa_1406306137:icl,ehl */

0 commit comments

Comments
 (0)