Skip to content

Commit 033c978

Browse files
jwrdegoedeJiri Kosina
authored andcommitted
HID: lenovo: Remove lenovo_led_brightness_get()
The led_classdev already contains a cached value of the last set brightness, the brightness_get callback is only meant for LED drivers which can read back the actual / current brightness from the hardware. Since lenovo_led_brightness_get() just returns the last set value it does not add any functionality, so we can just remove it. Reviewed-by: Marek Behún <kabel@kernel.org> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 34348a8 commit 033c978

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

drivers/hid/hid-lenovo.c

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -774,22 +774,6 @@ static void lenovo_led_set_tpkbd(struct hid_device *hdev)
774774
hid_hw_request(hdev, report, HID_REQ_SET_REPORT);
775775
}
776776

777-
static enum led_brightness lenovo_led_brightness_get(
778-
struct led_classdev *led_cdev)
779-
{
780-
struct device *dev = led_cdev->dev->parent;
781-
struct hid_device *hdev = to_hid_device(dev);
782-
struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
783-
int led_nr = 0;
784-
785-
if (led_cdev == &data_pointer->led_micmute)
786-
led_nr = 1;
787-
788-
return data_pointer->led_state & (1 << led_nr)
789-
? LED_FULL
790-
: LED_OFF;
791-
}
792-
793777
static int lenovo_led_brightness_set(struct led_classdev *led_cdev,
794778
enum led_brightness value)
795779
{
@@ -837,7 +821,6 @@ static int lenovo_register_leds(struct hid_device *hdev)
837821
snprintf(name_micm, name_sz, "%s:amber:micmute", dev_name(&hdev->dev));
838822

839823
data->led_mute.name = name_mute;
840-
data->led_mute.brightness_get = lenovo_led_brightness_get;
841824
data->led_mute.brightness_set_blocking = lenovo_led_brightness_set;
842825
data->led_mute.flags = LED_HW_PLUGGABLE;
843826
data->led_mute.dev = &hdev->dev;
@@ -846,7 +829,6 @@ static int lenovo_register_leds(struct hid_device *hdev)
846829
return ret;
847830

848831
data->led_micmute.name = name_micm;
849-
data->led_micmute.brightness_get = lenovo_led_brightness_get;
850832
data->led_micmute.brightness_set_blocking = lenovo_led_brightness_set;
851833
data->led_micmute.flags = LED_HW_PLUGGABLE;
852834
data->led_micmute.dev = &hdev->dev;

0 commit comments

Comments
 (0)