Skip to content

Commit 0378c62

Browse files
committed
dm: eliminate potential source of excessive kernel log noise
There wasn't ever a real need to log an error in the kernel log for ioctls issued with insufficient permissions. Simply return an error and if an admin/user is sufficiently motivated they can enable DM's dynamic debugging to see an explanation for why the ioctls were disallowed. Reported-by: Nir Soffer <nsoffer@redhat.com> Fixes: e980f62 ("dm: don't allow ioctls to targets that don't map to whole devices") Signed-off-by: Mike Snitzer <snitzer@redhat.com>
1 parent fcc4233 commit 0378c62

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/md/dm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ static int dm_blk_ioctl(struct block_device *bdev, fmode_t mode,
562562
* subset of the parent bdev; require extra privileges.
563563
*/
564564
if (!capable(CAP_SYS_RAWIO)) {
565-
DMWARN_LIMIT(
565+
DMDEBUG_LIMIT(
566566
"%s: sending ioctl %x to DM device without required privilege.",
567567
current->comm, cmd);
568568
r = -ENOIOCTLCMD;

0 commit comments

Comments
 (0)