Skip to content

Commit 038ff6f

Browse files
saschahauerchanwoochoi
authored andcommitted
PM / devfreq: rockchip-dfi: Handle LPDDR2 correctly
According to the downstream driver the DDRMON_CTRL_LPDDR23 bit must be set for both LPDDR2 and LPDDR3. Add the missing LPDDR2 case and while at it turn the if/else if/else into switch/case which makes it easier to read. Link: https://lore.kernel.org/all/20231018061714.3553817-12-s.hauer@pengutronix.de/ Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
1 parent 076b059 commit 038ff6f

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

drivers/devfreq/event/rockchip-dfi.c

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,19 @@ static void rockchip_dfi_start_hardware_counter(struct devfreq_event_dev *edev)
8383
DDRMON_CTRL_HARDWARE_EN), dfi_regs + DDRMON_CTRL);
8484

8585
/* set ddr type to dfi */
86-
if (dfi->ddr_type == ROCKCHIP_DDRTYPE_LPDDR3)
86+
switch (dfi->ddr_type) {
87+
case ROCKCHIP_DDRTYPE_LPDDR2:
88+
case ROCKCHIP_DDRTYPE_LPDDR3:
8789
writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR23, DDRMON_CTRL_DDR_TYPE_MASK),
8890
dfi_regs + DDRMON_CTRL);
89-
else if (dfi->ddr_type == ROCKCHIP_DDRTYPE_LPDDR4)
91+
break;
92+
case ROCKCHIP_DDRTYPE_LPDDR4:
9093
writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_MASK),
9194
dfi_regs + DDRMON_CTRL);
95+
break;
96+
default:
97+
break;
98+
}
9299

93100
/* enable count, use software mode */
94101
writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_SOFTWARE_EN, DDRMON_CTRL_SOFTWARE_EN),

0 commit comments

Comments
 (0)