pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output()

juhosg · Linus Walleij · commit 0396a8731efd · 2025-05-15T00:18:14.000+02:00
The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz <kaloz@openwrt.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-3-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -432,9 +432,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip,
 	reg = OUTPUT_EN;
 	armada_37xx_update_reg(&reg, &en_offset);
 
-	regmap_update_bits(info->regmap, reg, mask, mask);
-
-	return 0;
+	return regmap_update_bits(info->regmap, reg, mask, mask);
 }
 
 static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset)

Original file line number	Diff line number	Diff line change
`@@ -432,9 +432,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip,`
`432`	`432`	`reg = OUTPUT_EN;`
`433`	`433`	`armada_37xx_update_reg(&reg, &en_offset);`
`434`	`434`
`435`		`- regmap_update_bits(info->regmap, reg, mask, mask);`
`436`		`-`
`437`		`- return 0;`
	`435`	`+ return regmap_update_bits(info->regmap, reg, mask, mask);`
`438`	`436`	`}`
`439`	`437`
`440`	`438`	`static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset)`