x86/boot: Remove superfluous type casting from arch/x86/boot/bitops.h

likunyur · suryasaimadhu · commit 039f0e054a29 · 2022-08-15T19:17:43.000+02:00
'const void *' will auto-type-convert to just about any other const pointer type, no need to force it. [ mingo: Rewrote the changelog. ] Signed-off-by: Li kunyu <kunyu@nfschina.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Borislav Petkov <bp@suse.de> Link: https://lore.kernel.org/r/20220725042358.3377-1-kunyu@nfschina.com
diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h
@@ -19,13 +19,13 @@
 
 static inline bool constant_test_bit(int nr, const void *addr)
 {
-	const u32 *p = (const u32 *)addr;
+	const u32 *p = addr;
 	return ((1UL << (nr & 31)) & (p[nr >> 5])) != 0;
 }
 static inline bool variable_test_bit(int nr, const void *addr)
 {
 	bool v;
-	const u32 *p = (const u32 *)addr;
+	const u32 *p = addr;
 
 	asm("btl %2,%1" CC_SET(c) : CC_OUT(c) (v) : "m" (*p), "Ir" (nr));
 	return v;

Original file line number	Diff line number	Diff line change
`@@ -19,13 +19,13 @@`
`19`	`19`
`20`	`20`	`static inline bool constant_test_bit(int nr, const void *addr)`
`21`	`21`	`{`
`22`		`- const u32 p = (const u32 )addr;`
	`22`	`+ const u32 *p = addr;`
`23`	`23`	`return ((1UL << (nr & 31)) & (p[nr >> 5])) != 0;`
`24`	`24`	`}`
`25`	`25`	`static inline bool variable_test_bit(int nr, const void *addr)`
`26`	`26`	`{`
`27`	`27`	`bool v;`
`28`		`- const u32 p = (const u32 )addr;`
	`28`	`+ const u32 *p = addr;`
`29`	`29`
`30`	`30`	`asm("btl %2,%1" CC_SET(c) : CC_OUT(c) (v) : "m" (*p), "Ir" (nr));`
`31`	`31`	`return v;`