Skip to content

Commit 03a55b6

Browse files
committed
Merge tag 'bootconfig-fixes-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
Pull bootconfig fixes from Masami Hiramatsu: - show the original cmdline only once, and only if it was modeified by bootconfig * tag 'bootconfig-fixes-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace: fs/proc: Skip bootloader comment if no embedded kernel parameters fs/proc: remove redundant comments from /proc/bootconfig
2 parents 9875c0b + c722cea commit 03a55b6

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

fs/proc/bootconfig.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size)
6262
break;
6363
dst += ret;
6464
}
65-
if (ret >= 0 && boot_command_line[0]) {
66-
ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
67-
boot_command_line);
68-
if (ret > 0)
69-
dst += ret;
70-
}
65+
}
66+
if (cmdline_has_extra_options() && ret >= 0 && boot_command_line[0]) {
67+
ret = snprintf(dst, rest(dst, end), "# Parameters from bootloader:\n# %s\n",
68+
boot_command_line);
69+
if (ret > 0)
70+
dst += ret;
7171
}
7272
out:
7373
kfree(key);

include/linux/bootconfig.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#ifdef __KERNEL__
1111
#include <linux/kernel.h>
1212
#include <linux/types.h>
13+
bool __init cmdline_has_extra_options(void);
1314
#else /* !__KERNEL__ */
1415
/*
1516
* NOTE: This is only for tools/bootconfig, because tools/bootconfig will

init/main.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,11 @@ static int __init warn_bootconfig(char *str)
487487

488488
early_param("bootconfig", warn_bootconfig);
489489

490+
bool __init cmdline_has_extra_options(void)
491+
{
492+
return extra_command_line || extra_init_args;
493+
}
494+
490495
/* Change NUL term back to "=", to make "param" the whole string. */
491496
static void __init repair_env_string(char *param, char *val)
492497
{

0 commit comments

Comments
 (0)