Merge tag 'v6.19-rc2-smb3-client-fix' of git://git.samba.org/sfrench/cifs-2.6

torvalds · torvalds · commit 04688d6128b7 · 2025-12-26T16:19:45.000-08:00
Pull smb client fix from Steve French:

 - Fix potential memory leak

* tag 'v6.19-rc2-smb3-client-fix' of git://git.samba.org/sfrench/cifs-2.6:
  cifs: Fix memory and information leak in smb3_reconfigure()
diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
@@ -1139,6 +1139,8 @@ static int smb3_reconfigure(struct fs_context *fc)
 	rc = smb3_sync_session_ctx_passwords(cifs_sb, ses);
 	if (rc) {
 		mutex_unlock(&ses->session_mutex);
+		kfree_sensitive(new_password);
+		kfree_sensitive(new_password2);
 		return rc;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1139,6 +1139,8 @@ static int smb3_reconfigure(struct fs_context *fc)`
`1139`	`1139`	`rc = smb3_sync_session_ctx_passwords(cifs_sb, ses);`
`1140`	`1140`	`if (rc) {`
`1141`	`1141`	`mutex_unlock(&ses->session_mutex);`
	`1142`	`+ kfree_sensitive(new_password);`
	`1143`	`+ kfree_sensitive(new_password2);`
`1142`	`1144`	`return rc;`
`1143`	`1145`	`}`
`1144`	`1146`