Skip to content

Commit 048efe1

Browse files
pcacjrsmfrench
authored andcommitted
smb: client: fix oops due to uninitialised var in smb2_unlink()
If SMB2_open_init() or SMB2_close_init() fails (e.g. reconnect), the iovs set @Rqst will be left uninitialised, hence calling SMB2_open_free(), SMB2_close_free() or smb2_set_related() on them will oops. Fix this by initialising @close_iov and @open_iov before setting them in @Rqst. Reported-by: Thiago Becker <tbecker@redhat.com> Fixes: 1cf9f2a ("smb: client: handle unlink(2) of files open by different clients") Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org> Cc: David Howells <dhowells@redhat.com> Cc: linux-cifs@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 340cea8 commit 048efe1

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

fs/smb/client/smb2inode.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,7 @@ smb2_unlink(const unsigned int xid, struct cifs_tcon *tcon, const char *name,
12161216
memset(resp_buftype, 0, sizeof(resp_buftype));
12171217
memset(rsp_iov, 0, sizeof(rsp_iov));
12181218

1219+
memset(open_iov, 0, sizeof(open_iov));
12191220
rqst[0].rq_iov = open_iov;
12201221
rqst[0].rq_nvec = ARRAY_SIZE(open_iov);
12211222

@@ -1240,14 +1241,15 @@ smb2_unlink(const unsigned int xid, struct cifs_tcon *tcon, const char *name,
12401241
creq = rqst[0].rq_iov[0].iov_base;
12411242
creq->ShareAccess = FILE_SHARE_DELETE_LE;
12421243

1244+
memset(&close_iov, 0, sizeof(close_iov));
12431245
rqst[1].rq_iov = &close_iov;
12441246
rqst[1].rq_nvec = 1;
12451247

12461248
rc = SMB2_close_init(tcon, server, &rqst[1],
12471249
COMPOUND_FID, COMPOUND_FID, false);
1248-
smb2_set_related(&rqst[1]);
12491250
if (rc)
12501251
goto err_free;
1252+
smb2_set_related(&rqst[1]);
12511253

12521254
if (retries) {
12531255
/* Back-off before retry */

0 commit comments

Comments
 (0)