Skip to content

Commit 04db230

Browse files
Wei Yongjunvinodkoul
authored andcommitted
phy: qualcomm: fix return value check in qcom_ipq806x_usb_phy_probe()
In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: ef19b11 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Link: https://lore.kernel.org/r/20200723113622.136752-1-weiyongjun1@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent d86f908 commit 04db230

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,9 +505,9 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
505505
size = resource_size(res);
506506
phy_dwc3->base = devm_ioremap(phy_dwc3->dev, res->start, size);
507507

508-
if (IS_ERR(phy_dwc3->base)) {
508+
if (!phy_dwc3->base) {
509509
dev_err(phy_dwc3->dev, "failed to map reg\n");
510-
return PTR_ERR(phy_dwc3->base);
510+
return -ENOMEM;
511511
}
512512

513513
phy_dwc3->ref_clk = devm_clk_get(phy_dwc3->dev, "ref");

0 commit comments

Comments
 (0)