Skip to content

Commit 0503efe

Browse files
junfenggkuba-moo
authored andcommitted
gve: Set default duplex configuration to full
Current duplex mode was unset in the driver, resulting in the default parameter being set to 0, which corresponds to half duplex. It might mislead users to have incorrect expectation about the driver's transmission capabilities. Set the default duplex configuration to full, as the driver runs in full duplex mode at this point. Fixes: 7e074d5 ("gve: Enable Link Speed Reporting in the driver.") Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Message-ID: <20230706044128.2726747-1-junfeng.guo@intel.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 41b9eff commit 0503efe

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/net/ethernet/google/gve/gve_ethtool.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,9 @@ static int gve_get_link_ksettings(struct net_device *netdev,
590590
err = gve_adminq_report_link_speed(priv);
591591

592592
cmd->base.speed = priv->link_speed;
593+
594+
cmd->base.duplex = DUPLEX_FULL;
595+
593596
return err;
594597
}
595598

0 commit comments

Comments
 (0)