erofs: fix error return code in erofs_read_superblock()

Wei Yongjun · hsiangkao · commit 0508c1ad0f26 · 2021-06-08T00:40:18.000+08:00
'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true, thus 0 will return in some error handling cases. Fix to return negative error code -EINVAL instead of 0. Link: https://lore.kernel.org/r/20210519141657.3062715-1-weiyongjun1@huawei.com Fixes: b858a48 ("erofs: support superblock checksum") Cc: stable <stable@vger.kernel.org> # 5.5+ Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Gao Xiang <xiang@kernel.org> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Gao Xiang <xiang@kernel.org>
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
@@ -285,6 +285,7 @@ static int erofs_read_superblock(struct super_block *sb)
 			goto out;
 	}
 
+	ret = -EINVAL;
 	blkszbits = dsb->blkszbits;
 	/* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */
 	if (blkszbits != LOG_BLOCK_SIZE) {

Original file line number	Diff line number	Diff line change
`@@ -285,6 +285,7 @@ static int erofs_read_superblock(struct super_block *sb)`
`285`	`285`	`goto out;`
`286`	`286`	`}`
`287`	`287`
	`288`	`+ ret = -EINVAL;`
`288`	`289`	`blkszbits = dsb->blkszbits;`
`289`	`290`	`/* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */`
`290`	`291`	`if (blkszbits != LOG_BLOCK_SIZE) {`