ASoC: mt8192: Report an error if when an invalid sidetone gain is written

broonie · broonie · commit 05437a91173b · 2023-02-28T13:58:54.000Z
Reporting an error on invalid values is optional but helpful to userspace so do so. Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20230223-asoc-mt8192-quick-fixes-v1-3-9a85f90368e1@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c
@@ -601,6 +601,8 @@ static int stf_positive_gain_set(struct snd_kcontrol *kcontrol,
 					 POSITIVE_GAIN_MASK_SFT,
 					 (gain_db / 6) << POSITIVE_GAIN_SFT,
 					 &change);
+	} else {
+		return -EINVAL;
 	}
 
 	return change;

Original file line number	Diff line number	Diff line change
`@@ -601,6 +601,8 @@ static int stf_positive_gain_set(struct snd_kcontrol *kcontrol,`
`601`	`601`	`POSITIVE_GAIN_MASK_SFT,`
`602`	`602`	`(gain_db / 6) << POSITIVE_GAIN_SFT,`
`603`	`603`	`&change);`
	`604`	`+ } else {`
	`605`	`+ return -EINVAL;`
`604`	`606`	`}`
`605`	`607`
`606`	`608`	`return change;`