Skip to content

Commit 054e1c0

Browse files
haiyuewagregkh
authored andcommitted
uio: pci_sva: correct '-ENODEV' check logic
The current '-ENODEV' check uses '&&', which can lead to a NULL pointer dereference when udev is NULL. Fix the condition to return -ENODEV if either udev or its pdev is NULL. Fixes: 3397c3c ("uio: Add SVA support for PCI devices via uio_pci_generic_sva.c") Signed-off-by: Haiyue Wang <haiyuewa@163.com> Link: https://patch.msgid.link/20260109175448.34309-1-haiyuewa@163.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 26c08da commit 054e1c0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/uio/uio_pci_generic_sva.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static int uio_pci_sva_open(struct uio_info *info, struct inode *inode)
2929
struct uio_pci_sva_dev *udev = info->priv;
3030
struct iommu_domain *domain;
3131

32-
if (!udev && !udev->pdev)
32+
if (!udev || !udev->pdev)
3333
return -ENODEV;
3434

3535
domain = iommu_get_domain_for_dev(&udev->pdev->dev);
@@ -51,7 +51,7 @@ static int uio_pci_sva_release(struct uio_info *info, struct inode *inode)
5151
{
5252
struct uio_pci_sva_dev *udev = info->priv;
5353

54-
if (!udev && !udev->pdev)
54+
if (!udev || !udev->pdev)
5555
return -ENODEV;
5656

5757
iommu_sva_unbind_device(udev->sva_handle);

0 commit comments

Comments
 (0)