Skip to content

Commit 056b991

Browse files
committed
KVM: x86: Use cpu_feature_enabled() for PKU instead of #ifdef
Replace an #ifdef on CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS with a cpu_feature_enabled() check on X86_FEATURE_PKU. The macro magic of DISABLED_MASK_BIT_SET() means that cpu_feature_enabled() provides the same end result (no code generated) when PKU is disabled by Kconfig. No functional change intended. Cc: Jon Kohler <jon@nutanix.com> Reviewed-by: Jon Kohler <jon@nutanix.com> Link: https://lore.kernel.org/r/20230602010550.785722-1-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent 02f1b0b commit 056b991

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

arch/x86/kvm/x86.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1017,13 +1017,11 @@ void kvm_load_guest_xsave_state(struct kvm_vcpu *vcpu)
10171017
wrmsrl(MSR_IA32_XSS, vcpu->arch.ia32_xss);
10181018
}
10191019

1020-
#ifdef CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
1021-
if (static_cpu_has(X86_FEATURE_PKU) &&
1020+
if (cpu_feature_enabled(X86_FEATURE_PKU) &&
10221021
vcpu->arch.pkru != vcpu->arch.host_pkru &&
10231022
((vcpu->arch.xcr0 & XFEATURE_MASK_PKRU) ||
10241023
kvm_is_cr4_bit_set(vcpu, X86_CR4_PKE)))
10251024
write_pkru(vcpu->arch.pkru);
1026-
#endif /* CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS */
10271025
}
10281026
EXPORT_SYMBOL_GPL(kvm_load_guest_xsave_state);
10291027

@@ -1032,15 +1030,13 @@ void kvm_load_host_xsave_state(struct kvm_vcpu *vcpu)
10321030
if (vcpu->arch.guest_state_protected)
10331031
return;
10341032

1035-
#ifdef CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
1036-
if (static_cpu_has(X86_FEATURE_PKU) &&
1033+
if (cpu_feature_enabled(X86_FEATURE_PKU) &&
10371034
((vcpu->arch.xcr0 & XFEATURE_MASK_PKRU) ||
10381035
kvm_is_cr4_bit_set(vcpu, X86_CR4_PKE))) {
10391036
vcpu->arch.pkru = rdpkru();
10401037
if (vcpu->arch.pkru != vcpu->arch.host_pkru)
10411038
write_pkru(vcpu->arch.host_pkru);
10421039
}
1043-
#endif /* CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS */
10441040

10451041
if (kvm_is_cr4_bit_set(vcpu, X86_CR4_OSXSAVE)) {
10461042

0 commit comments

Comments
 (0)