Skip to content

Commit 05ca7e5

Browse files
committed
Merge branch 'pci/acpi'
- Replace acpi_bus_get_device() with acpi_fetch_acpi_dev() so we can drop acpi_bus_get_device() (Rafael J. Wysocki) * pci/acpi: PCI/ACPI: Replace acpi_bus_get_device() with acpi_fetch_acpi_dev()
2 parents e783362 + 9a607a5 commit 05ca7e5

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

drivers/pci/hotplug/acpiphp_glue.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,9 @@ static void acpiphp_post_dock_fixup(struct acpi_device *adev)
226226
static acpi_status acpiphp_add_context(acpi_handle handle, u32 lvl, void *data,
227227
void **rv)
228228
{
229+
struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
229230
struct acpiphp_bridge *bridge = data;
230231
struct acpiphp_context *context;
231-
struct acpi_device *adev;
232232
struct acpiphp_slot *slot;
233233
struct acpiphp_func *newfunc;
234234
acpi_status status = AE_OK;
@@ -238,15 +238,16 @@ static acpi_status acpiphp_add_context(acpi_handle handle, u32 lvl, void *data,
238238
struct pci_dev *pdev = bridge->pci_dev;
239239
u32 val;
240240

241+
if (!adev)
242+
return AE_OK;
243+
241244
status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
242245
if (ACPI_FAILURE(status)) {
243246
if (status != AE_NOT_FOUND)
244247
acpi_handle_warn(handle,
245248
"can't evaluate _ADR (%#x)\n", status);
246249
return AE_OK;
247250
}
248-
if (acpi_bus_get_device(handle, &adev))
249-
return AE_OK;
250251

251252
device = (adr >> 16) & 0xffff;
252253
function = adr & 0xffff;

drivers/pci/hotplug/acpiphp_ibm.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,9 @@ static int __init ibm_acpiphp_init(void)
433433
goto init_return;
434434
}
435435
pr_debug("%s: found IBM aPCI device\n", __func__);
436-
if (acpi_bus_get_device(ibm_acpi_handle, &device)) {
437-
pr_err("%s: acpi_bus_get_device failed\n", __func__);
436+
device = acpi_fetch_acpi_dev(ibm_acpi_handle);
437+
if (!device) {
438+
pr_err("%s: acpi_fetch_acpi_dev failed\n", __func__);
438439
retval = -ENODEV;
439440
goto init_return;
440441
}

drivers/pci/pci-acpi.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ int acpi_get_rc_resources(struct device *dev, const char *hid, u16 segment,
8989
return -ENODEV;
9090
}
9191

92-
ret = acpi_bus_get_device(handle, &adev);
93-
if (ret)
94-
return ret;
92+
adev = acpi_fetch_acpi_dev(handle);
93+
if (!adev)
94+
return -ENODEV;
9595

9696
ret = acpi_get_rc_addr(adev, res);
9797
if (ret) {

0 commit comments

Comments
 (0)