Skip to content

Commit 05f929b

Browse files
jhovoldgregkh
authored andcommitted
serial: liteuart: fix use-after-free and memleak on unbind
Deregister the port when unbinding the driver to prevent it from being used after releasing the driver data and leaking memory allocated by serial core. Fixes: 1da81e5 ("drivers/tty/serial: add LiteUART driver") Cc: stable@vger.kernel.org # 5.11 Cc: Filip Kokosinski <fkokosinski@antmicro.com> Cc: Mateusz Holenko <mholenko@antmicro.com> Reviewed-by: Stafford Horne <shorne@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20211117100512.5058-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0f55f89 commit 05f929b

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/tty/serial/liteuart.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,7 @@ static int liteuart_remove(struct platform_device *pdev)
295295
struct uart_port *port = platform_get_drvdata(pdev);
296296
struct liteuart_port *uart = to_liteuart_port(port);
297297

298+
uart_remove_one_port(&liteuart_driver, port);
298299
xa_erase(&liteuart_array, uart->id);
299300

300301
return 0;

0 commit comments

Comments
 (0)